Skip to content

nixos/systemd: make [email protected] optional #468325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ElvishJerricco merged 1 commit into from
Dec 7, 2025
Merged

nixos/systemd: make [email protected] optional #468325

ElvishJerricco merged 1 commit into from
Dec 7, 2025
+4 −2

Conversation

@MatthewCroughan
Copy link
Contributor

@MatthewCroughan MatthewCroughan commented Dec 6, 2025 •
edited
Loading

Things done

After #451781 this should have been made optional, otherwise trying to use systemdMinimal as your systemd package results in this path being forcefully added with no way to remove it.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

ElvishJerricco
ElvishJerricco reviewed Dec 6, 2025
View reviewed changes
@MatthewCroughan MatthewCroughan force-pushed the mc/nspawn-optional branch 2 times, most recently from 979f599 to 422d5fc Compare December 6, 2025 05:18
ElvishJerricco
ElvishJerricco previously approved these changes Dec 6, 2025
View reviewed changes
ElvishJerricco
ElvishJerricco requested changes Dec 6, 2025
View reviewed changes
Copy link
Contributor

@ElvishJerricco ElvishJerricco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add withNspawn to the package passthru. Please do actually eval / test your changes.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Dec 7, 2025
@ElvishJerricco ElvishJerricco added this pull request to the merge queue Dec 7, 2025
Merged via the queue into NixOS:master with commit 38b523e Dec 7, 2025
32 of 35 checks passed
@MatthewCroughan MatthewCroughan deleted the mc/nspawn-optional branch December 7, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElvishJerricco ElvishJerricco ElvishJerricco approved these changes

@nikstur nikstur Awaiting requested review from nikstur

@aanderse aanderse Awaiting requested review from aanderse

@arianvp arianvp Awaiting requested review from arianvp

@flokli flokli Awaiting requested review from flokli

@LordGrimmauld LordGrimmauld Awaiting requested review from LordGrimmauld

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MatthewCroughan @ElvishJerricco