{libbladeRF,uhd}: fix darwin-aarch64 builds by fmeef · Pull Request #457704 · NixOS/nixpkgs

fmeef · 2025-11-02T03:40:49Z

Fix build of two specific gnuradio dependencies on aarch64-darwin. libbladeRF and uhd both had issues building specifically on aarch64-darwin.

doronbehar · 2025-11-02T09:33:40Z

@@ -62,7 +62,7 @@ stdenv.mkDerivation rec {
  ];

  env = lib.optionalAttrs stdenv.cc.isClang {
-    NIX_CFLAGS_COMPILE = "-Wno-error=unused-but-set-variable";
+    NIX_CFLAGS_COMPILE = "-Wno-error=unused-but-set-variable -Wno-error=tautological-overlap-compare";


Same here. I never had direct access to Darwin machines along with the motivation to do so to test this thoroughly, but it'd be great to debug these build failures with upstream. They seem to be pretty active. Also, cc @cyclic-pentane per Nuand/bladeRF#984 (comment) - I assume they have some relevant knowledge :).

Unfortunately not - but I also have an aarch64-darwin machine I'm using Nix on, so I might try to debug this one of these days too.

I'm also waiting here for more clues regarding libbladerf darwin CFLAGS.

doronbehar · 2025-11-03T07:28:31Z

+(
+  if stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64 then
+    llvmPackages_20.stdenv
+  else
+    stdenv
+).mkDerivation
+  (finalAttrs: {


To minimize the diff, it'd be a bit better to use a buildStdenv variable in the let in above, and use it here. This PR change is still missing a description of the errors you get with the regular stdenv, and is still missing a link to a discussion or an attempt to discuss the failures with upstream.

for uhd the error is

/nix/store/hn2ph6rpxfqkc46xjvlvmiypmznn748f-boost-1.87.0-dev/include/boost/type_traits/is_signed.hpp:37:38: note: integer value -1 is outside the valid range of values [0, 127] for the enumeration type 'stream_mode_t' 37 | static const no_cv_t minus_one = (static_cast<no_cv_t>(-1)); | ^ In file included from /nix/var/nix/builds/nix-50132-1640262001/source/host/lib/usrp/cores/rx_dsp_core_200.cpp:9: In file included from /nix/var/nix/builds/nix-50132-1640262001/source/host/include/uhd/types/dict.hpp:156: In file included from /nix/var/nix/builds/nix-50132-1640262001/source/host/include/uhd/types/dict.ipp:13: In file included from /nix/store/hn2ph6rpxfqkc46xjvlvmiypmznn748f-boost-1.87.0-dev/include/boost/lexical_cast.hpp:33: In file included from /nix/store/hn2ph6rpxfqkc46xjvlvmiypmznn748f-boost-1.87.0-dev/include/boost/lexical_cast/try_lexical_convert.hpp:31: In file included from /nix/store/hn2ph6rpxfqkc46xjvlvmiypmznn748f-boost-1.87.0-dev/include/boost/lexical_cast/detail/converter_numeric.hpp:31: In file included from /nix/store/hn2ph6rpxfqkc46xjvlvmiypmznn748f-boost-1.87.0-dev/include/boost/type_traits/make_unsigned.hpp:15: /nix/store/hn2ph6rpxfqkc46xjvlvmiypmznn748f-boost-1.87.0-dev/include/boost/type_traits/is_unsigned.hpp:38:25: error: in-class initializer for static data member is not a constant expression 38 | static const no_cv_t minus_one = (static_cast<no_cv_t>(-1)); | ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~

and for libbladeRF the error is

[ 79%] Building C object host/utilities/bladeRF-fsk/c/CMakeFiles/bladeRF-fsk_test_suite.dir/src/crc32.c.o /nix/var/nix/builds/nix-31591-1882500057/source/host/utilities/bladeRF-cli/src/cmd/flash_image.c:71:35: error: overlapping comparisons always evaluate to true [-Werror,-Wtautological-overlap-compare] 71 | if (val[i] >= 'a' || val[i] <= 'f') { | ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ 1 error generated.

doronbehar

The PR's commits should be:

libbladerf: fix build on Darwin
uhd: fix unit tests on aarch64-darwin

And note the unresolved review comments.

doronbehar · 2025-11-04T06:59:42Z

@@ -32,13 +32,21 @@
  enableN320 ? true,
  enableE300 ? true,
  enableE320 ? true,
+  llvmPackages_20,


Could you please move this argument upwards near stdenv? There is a sort of category division of the various arguments and this breaks this division.

doronbehar · 2025-11-04T07:01:50Z

+  mkDerivation =
+    (
+      if stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64 then
+        llvmPackages_20.stdenv
+      else
+        stdenv
+    ).mkDerivation;
 in

-stdenv.mkDerivation (finalAttrs: {
+mkDerivation (finalAttrs: {


In principal, when modifying stdenv like this, one should use a variable named stdenv', and then also modify all stdenv usages below to be stdenv', as the boolean flags evaluated below in principal can change due to such a conditional.

doronbehar · 2025-11-04T07:02:19Z

 }:

 let
  inherit (lib) optionals cmakeBool;
+  mkDerivation =
+    (
+      if stdenv.hostPlatform.isDarwin && stdenv.hostPlatform.isAarch64 then


This PR is still missing an attempt to discuss the failures with upstream.

I opened an issue here EttusResearch/uhd#881

I opened an issue here EttusResearch/uhd#881

Thanks, let's give them a few days to reply. I subscribed to the issue.

doronbehar · 2025-11-04T09:11:49Z

@@ -181,7 +188,7 @@ stdenv.mkDerivation (finalAttrs: {
  ];

  # many tests fails on darwin, according to ofborg


Speaking of Darwin, have you tried to enable the tests?

doronbehar

@fmeef I just realized I had a stale review here (written below). The UHD darwin build failure issue is pretty active and I just wrote there a message regarding the workaround applied here. I also forgot about this PR while working on #481933 . Since I'm still a bit hesitant as for the libbladeRF change, I copied the UHD changes here into #481933 while giving you credit.

doronbehar · 2025-11-04T09:14:26Z

@@ -62,7 +62,7 @@ stdenv.mkDerivation rec {
  ];

  env = lib.optionalAttrs stdenv.cc.isClang {
-    NIX_CFLAGS_COMPILE = "-Wno-error=unused-but-set-variable";
+    NIX_CFLAGS_COMPILE = "-Wno-error=unused-but-set-variable -Wno-error=tautological-overlap-compare";


I'm also waiting here for more clues regarding libbladerf darwin CFLAGS.

ofborg Bot added the 6.topic: darwin Running or building packages on Darwin label Nov 2, 2025

nixpkgs-ci Bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels Nov 2, 2025

nix-owners Bot requested review from bjornfor, doronbehar, fpletz, markuskowa and tomberek November 2, 2025 03:46

fmeef force-pushed the darwin_bladerf branch from 67eb493 to 18fc74d Compare November 2, 2025 03:56

doronbehar requested changes Nov 2, 2025

View reviewed changes

fmeef force-pushed the darwin_bladerf branch 6 times, most recently from bae3489 to 8c037d8 Compare November 2, 2025 20:19

doronbehar requested changes Nov 3, 2025

View reviewed changes

fmeef force-pushed the darwin_bladerf branch 5 times, most recently from 89dd1e9 to f7262a9 Compare November 4, 2025 05:23

doronbehar requested changes Nov 4, 2025

View reviewed changes

fmeef added 2 commits November 4, 2025 02:31

libbladerf: fix build on Darwin

dbfa4e2

uhd: fix unit tests on aarch64-darwin

e2914ff

fmeef force-pushed the darwin_bladerf branch from f7262a9 to e2914ff Compare November 4, 2025 09:00

doronbehar reviewed Nov 4, 2025

View reviewed changes

doronbehar changed the title ~~Fix build of libbladeRF and uhd on darwin-aarch64~~ {libbladeRF,uhd}: fix darwin-aarch64 builds Nov 4, 2025

sikmir mentioned this pull request Nov 11, 2025

sdrpp: fix darwin build & server mode, add options, simplify #452963

Merged

13 tasks

doronbehar reviewed Jan 20, 2026

View reviewed changes

doronbehar mentioned this pull request Jan 20, 2026

uhd: fix Darwin build (fixes also Gnuradio build) #481933

Merged

13 tasks

nixpkgs-ci Bot added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 12.first-time contribution This PR is the author's first one; please be gentle! labels Jan 22, 2026

		@@ -181,7 +188,7 @@ stdenv.mkDerivation (finalAttrs: {
		];

		# many tests fails on darwin, according to ofborg

Uh oh!

Uh oh!

Conversation

fmeef commented Nov 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

doronbehar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fmeef Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

doronbehar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fmeef commented Nov 2, 2025 •

edited

Loading

fmeef Nov 4, 2025 •

edited

Loading