Access list clients ordered insert#5421
Open
edklesel wants to merge 2 commits intoNginxProxyManager:developfrom
Open
Access list clients ordered insert#5421edklesel wants to merge 2 commits intoNginxProxyManager:developfrom
edklesel wants to merge 2 commits intoNginxProxyManager:developfrom
Conversation
|
Docker Image for build 1 is available on DockerHub: Note Ensure you backup your NPM instance before testing this image! Especially if there are database changes. Warning Changes and additions to DNS Providers require verification by at least 2 members of the community! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #5405.
Using promises for access list clients does not seem to guarantee that the order is preserved, however the order of access lists is very important and the UI says as such.
Therefore, change the client inserts to run sequentially. This may increase time for extremely large access lists, however the order will be preserved.