Health Check OR-requirement E2E tests + atomic step refactor (LAZ-911) - #23901
Draft
chnexusmods wants to merge 1 commit into
Draft
Health Check OR-requirement E2E tests + atomic step refactor (LAZ-911)#23901chnexusmods wants to merge 1 commit into
chnexusmods wants to merge 1 commit into
Conversation
…AZ-911) Cover the file-requirement "pick one of several alternatives" (OR) case: - SDV_OR_FILE_REQUIREMENT_MOD_URL (47938) fixture + openOrFileRequirementWarning helper (DRY-shared with the missing-requirement opener via installAndSurfaceFileWarning). - HealthCheckWarnings.pickModInstall() and HealthCheckDetail pickOneHeader / requiresPickLine / orDivider POM members. - Free-user render test (the "Pick mod install" / "Pick one of these" / "to be picked" / "Or" divider choice UI) and a premium resolve test (picking one alternative satisfies the OR and clears the warning). Also refactor the file-requirement spec to the one-action/one-assertion pattern in E2E-BEST-PRACTICES.md: split hover-reveal from click, reason-select from send, per-mod manual downloads, spy-arm from link-open, and install from the return-to-list observation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
chnexusmods
force-pushed
the
christopherhardy-laz-911
branch
from
August 6, 2026 15:06
156a0f3 to
c891cd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds E2E coverage for the File Requirements Health Check OR case — a requirement satisfiable by more than one alternative ("this file or that file"), where the user must pick one:
SDV_OR_FILE_REQUIREMENT_MOD_URL(SDV mod 47938) + a DRY-sharedopenOrFileRequirementWarninghelper (installAndSurfaceFileWarning).HealthCheckWarnings.pickModInstall(), andHealthCheckDetail.pickOneHeader/requiresPickLine/orDivider.Also refactors the file-requirement spec to the one-action / one-assertion pattern from
E2E-BEST-PRACTICES.md(split hover-reveal from click, reason-select from send, per-mod manual downloads, spy-arm from link-open, and install from the return-to-list observation).Why draft
The tests are statically green (typecheck + lint + format) but not yet runtime-validated — local E2E is captcha-blocked, so the
e2e (vortex-e2e)CI leg is the first real run. Leaving as a draft until CI confirms:toBeHidden) after install;sendButtonenabling after a feedback reason is chosen; the warning persisting until the last manual download.If any of those fails, I'll adjust the fixture/assertions before marking it ready for review.
🤖 Generated with Claude Code