Update nwb-schema to 2.11.0 and require HDMF 6.2.0 - #2244
Open
rly wants to merge 5 commits into
Open
Conversation
Point the nwb-schema submodule at f7dae71 ("Prepare 2.11.0 release" on
the prepare_2.11.0 branch), which sets the schema version to 2.11.0 and
brings in hdmf-common-schema 1.10.0. Update the changelog entry to name
2.11.0 and record the MeaningsTable.target change and the HDMF 6.2.0
requirement it carries.
This branch exists so nwb-schema#710 can verify PyNWB against the
release candidate. Retarget the submodule at the 2.11.0 tag once that
PR merges and the tag is pushed.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
HDMF 6.2.0 bundles HDMF Common Schema 1.10.0, the same version NWB Schema 2.11.0 carries, so the Python-side MeaningsTable definition matches the schema's object-reference `target` attribute. It also writes the `unit` and `time_before_peak_in_ms` attributes on the `Units` waveform columns, which fell back to their schema defaults under HDMF 6.1.0. Raise the floor in pyproject.toml and pin the ROS3 environment to 6.2.0. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2244 +/- ##
=======================================
Coverage 96.22% 96.22%
=======================================
Files 30 30
Lines 2993 2993
Branches 433 433
=======================================
Hits 2880 2880
Misses 64 64
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
nwb-users.slack.com returns 403 to unauthenticated requests, so the linkcheck job reports the CONTRIBUTING links to it as broken. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
nwb-schemasubmodule to the NWB Schema 2.11.0 release candidate and raises the minimum HDMF version to 6.2.0.Companion to NeurodataWithoutBorders/nwb-schema#710, which covers the "Ensure PyNWB and MatNWB have branches that have passing tests" item on that release checklist.
Changes
src/pynwb/nwb-schemaatf7dae71("Prepare 2.11.0 release"), which sets the schema version to 2.11.0 and brings in HDMF Common Schema 1.10.0.hdmffrom>=6.1.0,<7to>=6.2.0,<7inpyproject.toml, and pinnedenvironment-ros3.ymltohdmf==6.2.0.MeaningsTable.targetchange and the HDMF floor bump.Why HDMF 6.2.0 is required
NWB Schema 2.11.0 carries HDMF Common Schema 1.10.0, which changes
MeaningsTable.targetfrom a link to an object-reference attribute. HDMF 6.2.0 bundles that same schema version (e7f84f0), so the Python-sideMeaningsTabledefinition matches. HDMF 6.1.0 bundles 1.9.0 and still treatstargetas a link.HDMF 6.2.0 also fixes writing the
unitandtime_before_peak_in_msattributes on theUnitswaveform columns. Under 6.1.0 both fell back to their schema defaults on write, soTestUnitsCustomWaveformUnitIOandTestUnitsWaveformTimeBeforePeakIOfailed ondevregardless of which schema commit the submodule pointed at.Testing
Full suite run locally against schema 2.11.0 with HDMF 6.2.0:
For comparison, the same suite on
devwith HDMF 6.1.0 gives 8 failed, 844 passed, 6764 subtests passed. All 8 failures are the two waveform test classes described above and are resolved by the HDMF bump.Before merging
The submodule points at a commit on the
prepare_2.11.0branch of nwb-schema, not a tag. Retarget it at the2.11.0tag once nwb-schema#710 merges and the tag is pushed.🤖 Generated with Claude Code