Skip to content

Fix DynamicTableRegion upper-bound validation - #721

Open
AtomicGlance wants to merge 1 commit into
NeurodataWithoutBorders:devfrom
AtomicGlance:agent/fix-dynamic-table-region-bounds
Open

AtomicGlance wants to merge 1 commit into
NeurodataWithoutBorders:devfrom
AtomicGlance:agent/fix-dynamic-table-region-bounds

Conversation

@AtomicGlance

Copy link
Copy Markdown

Summary

DynamicTableRegion stores zero-based row indices, so the largest valid value is len(table) - 1. The validator previously allowed an index equal to len(table), which is out of bounds.

This change:

  • rejects indices greater than or equal to the target table length;
  • updates the diagnostic message to describe the inclusive upper bound; and
  • adds a regression test for the exact boundary value.

Validation

  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest tests/unit_tests/test_tables.py -q — 48 passed
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 python -m pytest tests/unit_tests -q — 294 passed, 7 skipped

@AtomicGlance
AtomicGlance marked this pull request as ready for review August 11, 2026 21:50
@AtomicGlance

Copy link
Copy Markdown
Author

I verified the DynamicTableRegion boundary fix locally; the focused table tests pass (48 passed), and the available CI checks are green. The PR is ready for review.

@AtomicGlance
AtomicGlance force-pushed the agent/fix-dynamic-table-region-bounds branch from 40d0425 to 8a552eb Compare September 9, 2026 17:49
@AtomicGlance

Copy link
Copy Markdown
Author

Rebased the DynamicTableRegion boundary fix onto the current dev branch and pushed the refreshed branch. The focused boundary tests pass (4 passed), and the change remains limited to the table check and regression coverage.

@AtomicGlance
AtomicGlance force-pushed the agent/fix-dynamic-table-region-bounds branch from 8a552eb to e59a83c Compare September 9, 2026 18:17
@AtomicGlance

Copy link
Copy Markdown
Author

The branch is now rebased onto the latest dev and force-updated. The full table unit module passes locally (53 passed); the boundary fix remains isolated to the intended check and tests.

@AtomicGlance
AtomicGlance force-pushed the agent/fix-dynamic-table-region-bounds branch from e59a83c to ca0ea77 Compare September 9, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant