Fix DynamicTableRegion upper-bound validation - #721
Open
AtomicGlance wants to merge 1 commit into
Open
AtomicGlance wants to merge 1 commit into
AtomicGlance wants to merge 1 commit into
Conversation
AtomicGlance
marked this pull request as ready for review
August 11, 2026 21:50
Author
|
I verified the DynamicTableRegion boundary fix locally; the focused table tests pass (48 passed), and the available CI checks are green. The PR is ready for review. |
AtomicGlance
force-pushed
the
agent/fix-dynamic-table-region-bounds
branch
from
September 9, 2026 17:49
40d0425 to
8a552eb
Compare
Author
|
Rebased the DynamicTableRegion boundary fix onto the current dev branch and pushed the refreshed branch. The focused boundary tests pass (4 passed), and the change remains limited to the table check and regression coverage. |
AtomicGlance
force-pushed
the
agent/fix-dynamic-table-region-bounds
branch
from
September 9, 2026 18:17
8a552eb to
e59a83c
Compare
Author
|
The branch is now rebased onto the latest |
AtomicGlance
force-pushed
the
agent/fix-dynamic-table-region-bounds
branch
from
September 9, 2026 18:42
e59a83c to
ca0ea77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamicTableRegion stores zero-based row indices, so the largest valid value is len(table) - 1. The validator previously allowed an index equal to len(table), which is out of bounds.
This change:
Validation