Open
Conversation
…ror if the user wanted to print the parameter times for a DCSource for exemple. Did the same for amplitudes variable. Changed the condition if in set_native_parameters to implement those changes. Added a get_native_parameters function to print a error if the user prints a parameter that doesn't exist.
…tep_times) to change the type list to an array. Did the same for step_amplitudes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was that when a user was trying to print the variable times from a DCSource it didn't showed an error but an array. I changed All the variable named times by _times. I did the same thing for amplitudes. Except for these two I didn't change the name of the variable for StepCurrentSource. I also added a get_native_parameters because when the user was trying to print a variable which didn't exist, there was an NotImplementedError insted of the correct error. At last, I changed the type of the variable that was returned in _check_step_time from a list to an array.