Bind shifted affine virtuals to source columns - #233
Open
latifkasuli wants to merge 1 commit into
Open
Conversation
latifkasuli
marked this pull request as ready for review
August 18, 2026 14:34
latifkasuli
requested review from
albert-garreta and
frozenspider
as code owners
August 18, 2026 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goes towards #185, which blocks #91. Follow-up to #230.
This extends affine virtual Booleanity targets to forward-row-shifted sources:
Shifts at or beyond the trace domain now consistently represent the all-zero, zero-padded column in both the prover MLE selector and verifier shift predicate. The affine materializer also handles index overflow as an out-of-range row.
Affine virtuals remain uncommitted Booleanity targets, so shifted witness terms reuse existing committed source openings and add no PCS commitments. SHA-256/ECDSA UAIR adoption remains separate.
Tests cover shifted witness-only and public-only paths, interleaved public/witness ordering across two witness sources, first-occurrence deduplication and appended-source indices, signature-derived length rejection, tampered shifted claims, and shifts equal to or greater than the trace length.