Fix duplicate DB write and log in UpdateHeadBlock#10648
Open
davidjsonn wants to merge 2 commits intoNethermindEth:masterfrom
Open
Fix duplicate DB write and log in UpdateHeadBlock#10648davidjsonn wants to merge 2 commits intoNethermindEth:masterfrom
davidjsonn wants to merge 2 commits intoNethermindEth:masterfrom
Conversation
davidjsonn
requested review from
LukaszRozmej,
MarekM25 and
flcl42
as code owners
Member
|
Interesting, comes from here: https://github.com/NethermindEth/nethermind/pull/3805/changes#diff-d27c737597e06baaba78d4fc5e2065b9d5d964b141c2fe343c4075655f2b9c22R1660-R1661 @MarekM25 it is probably a mistake? |
LukaszRozmej
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove duplicate log and DB write in UpdateHeadBlock.
The log message and _blockInfoDb.Set() were called twice: once before the header lookup, and again inside the success branch.
This change also ensures the DB write only occurs when the header is found.