Skip to content

Preserve tool subcommands when forwarding verbose output - #96

Merged
DanielThomas merged 2 commits into
mainfrom
fix/verbose-tool-subcommands
Oct 22, 2026
Merged

DanielThomas merged 2 commits into
mainfrom
fix/verbose-tool-subcommands

Conversation

@DanielThomas

@DanielThomas DanielThomas commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Fix ja --verbose prepending --verbose ahead of delegated subcommands, which causes jig to misinterpret Maven and Gradle options.

Use one shared helper for direct tool calls and resolution calls. Insert the flag before existing options, keeping leading subcommands first, and avoid duplicating an existing verbose option. Keep the -- operand separator intact. This also keeps jar options ahead of its file inputs.

Validation:

  • The Maven/Gradle and direct-tool regressions fail against current main before the fix.
  • A real jar-creation regression reproduces the CI assembly failure from appending the flag after file inputs.
  • All 79 tests in the affected test classes pass.
  • All 494 tests pass with the built ja and its current tool bundle.

Rebased onto current main, including jig 0.21.1.

@DanielThomas
DanielThomas merged commit 4f873c3 into main Oct 22, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant