Repository navigation
Handle tools requiring unresolved system modules - #93
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix installation and dynamic tool discovery when an application requires system modules that are present in the JDK but absent from ja's hosting layer, as reported in #90.
java.se/ALL-SYSTEMstartup roots or JDK-internal APIs.Validation
java.sql,java.se, andjdk.xml.dom, bothToolProviderandjavax.tools.Tool, activated providers, source overrides, and warmup metadata.jigdoes not invoke the Java launcher, and compare process IDs for dynamic tools with and without additional system-module requirements.ja test --all: 490/491 passing. The only failure is the pre-existingJmhToolProviderTest.discoversAndRunsAModularBenchmark, whose server-socket bind is denied by the sandbox (SocketException: Operation not permitted).ja test --all com.netflix.tools.ja.test.InstallerTest: 22/22 passing.git diff --checkpasses.