#Fixes #100: Update to schema43#101
Open
t-book wants to merge 1 commit intoNaturalHistoryMuseum:devfrom
Open
Conversation
alycejenni
requested changes
Apr 2, 2024
Member
alycejenni
left a comment
There was a problem hiding this comment.
Thank you for doing this! Unfortunately there are a few more changes that are needed before we can merge this:
schema42is still referenced intest_generate.py,README.md,interfaces.py, andmetadata.pyschemeURIneeds to be changed back toschemeUri; ideally we should probably have a test for this but I won't reject a PR without one because we don't currently have one and it's not new functionality- please make sure you read the contributing guidelines for commits for your new commits
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alycejenni From my tests this PR covers what is needed to update to the last available schema43 (@ datacite api wrapper). In case I forget something I'm happy about your guidance and working on it.
Overview
https://schema.datacite.org/meta/kernel-4.3/
Since schema43 affilations can look like
Instead of the following with scheme42
Hence, my feature request is to upgrade the plugin to use schema43
Possible Solutions
From my tests it works to just bump to schema43 and use it in later code lines as proposed by the PR
ckanext-doi/ckanext/doi/lib/api.py
Line 15 in 59942cf