Skip to content

GeniePlus: fix Guzzle error handling. #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
demiankatz wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

GeniePlus: fix Guzzle error handling. #206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/RecordManager/Base/Harvest/GeniePlus.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
*
* PHP version 8
*
* Copyright (c) Villanova University 2022.
* Copyright (c) Villanova University 2022-2026.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2,
Expand Down Expand Up @@ -401,7 +401,11 @@ protected function sendRequest($path, $params): MessageInterface
for ($try = 1; $try <= $maxTries; $try++) {
$this->infoMsg("Sending request: $url");
try {
$response = $client->get($url, compact('headers'));
try {
$response = $client->get($url, compact('headers'));
} catch (\GuzzleHttp\Exception\BadResponseException $e) {
$response = $e->getResponse();
}
$code = $response->getStatusCode();
if ($code == 404) {
return $response;
Expand Down