Skip to content

Add GHEs to Equipment Summary#11643

Open
rraustad wants to merge 1 commit into
developfrom
5571-Add-GHE-to-html-Equipment-Summary
Open

Add GHEs to Equipment Summary#11643
rraustad wants to merge 1 commit into
developfrom
5571-Add-GHE-to-html-Equipment-Summary

Conversation

@rraustad

Copy link
Copy Markdown
Collaborator

Pull request overview

Description of the purpose of this PR

Adds new html table for ground heat exchangers to html equipment summary report.

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added the Defect Includes code to repair a defect in EnergyPlus label Jun 16, 2026
@rraustad

Copy link
Copy Markdown
Collaborator Author

Example file GSHPSimple-GLHE:

image

Example file GSHP-GLHE:

image

Example file GSHP-Slinky:

image

@rraustad rraustad self-assigned this Jun 16, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Regressions detected on macos-14 for commit 2d524e2

Regression Summary
  • Audit: 814

@github-actions

Copy link
Copy Markdown

⚠️ Regressions detected on ubuntu-24.04 for commit 2d524e2

Regression Summary
  • Audit: 818

@rraustad

Copy link
Copy Markdown
Collaborator Author

Audit diffs only. 5ZoneAirCooled audit diffs:

image

@brianlball brianlball requested a review from mitchute June 17, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Water and GroundHeatExchanger:* and HeatPump:WaterToWater:* to Equipment Summary table

2 participants