Skip to content

fix malformed hookscratch dir names - #2042

Merged
tariq1890 merged 1 commit into
mainfrom
hook-scratch-dir-path
Sep 2, 2026
Merged

fix malformed hookscratch dir names#2042
tariq1890 merged 1 commit into
mainfrom
hook-scratch-dir-path

Conversation

@tariq1890

Copy link
Copy Markdown
Contributor

This was created in response to a review comment in PR #2040.

  • params_linux and ldconfig_linux are now aligned in how they generate the hook scratch directory
  • uses filepath.Join so it's more idiomatic

Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 33653977527

Coverage remained the same at 43.634%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: 2 uncovered changes across 2 files (0 of 2 lines covered, 0.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
cmd/nvidia-cdi-hook/disable-device-node-modification/params_linux.go 1 0 0.0%
internal/ldconfig/ldconfig_linux.go 1 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13430
Covered Lines: 5860
Line Coverage: 43.63%
Coverage Strength: 0.44 hits per line

💛 - Coveralls

@tariq1890
tariq1890 merged commit 43e8235 into main Sep 2, 2026
34 of 35 checks passed
@tariq1890
tariq1890 deleted the hook-scratch-dir-path branch September 2, 2026 20:07
@tariq1890 tariq1890 self-assigned this Sep 2, 2026
@tariq1890

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-1.20

@github-actions

Copy link
Copy Markdown

🤖 Backport PR created for release-1.20: #2073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants