add support for azure blob for inference results#712
Draft
shrek wants to merge 7 commits intoNVIDIA:mainfrom
Draft
add support for azure blob for inference results#712shrek wants to merge 7 commits intoNVIDIA:mainfrom
shrek wants to merge 7 commits intoNVIDIA:mainfrom
Conversation
Contributor
Greptile SummaryThis PR adds Azure Blob Storage support as an alternative to AWS S3 for storing inference results. The implementation includes SAS token generation for Azure signed URLs, comprehensive documentation, and configuration options for both storage providers. Major Changes:
Critical Issues Found:
|
| Filename | Overview |
|---|---|
| serve/inferenceserver/api_server/object_storage.py | Added Azure Blob Storage support with SAS URL generation. Critical issue: duplicated S3 configuration code (lines 302-322) that will break Azure storage initialization. |
| serve/inferenceserver/api_server/cpu_worker.py | Updated to handle both S3 and Azure storage types. Critical issue: incorrect import path (earth2studio_api_server instead of api_server) will cause import failure. |
| serve/inferenceserver/api_server/config.py | Added Azure configuration parameters and environment variable overrides. Clean implementation with proper type hints. |
| serve/inferenceserver/requirements.txt | Added Azure Blob Storage dependencies with multi-storage-client Azure support. |
| pyproject.toml | Added object storage dependencies to serve extras group. |
Last reviewed commit: df42f31
Contributor
Additional Comments (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earth2Studio Pull Request
Description
This PR adds azure blob support for inference results.
Checklist
Dependencies