Add sliding-window attention support to the SM120 FROST SDPA backward engine - #505
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughSM120 SDPA backward now supports optional left sliding-window masking. The change updates API propagation, validation, engine lowering, kernel masking and LSE handling, cache specialization, and coverage for causal and non-causal configurations. ChangesSM120 sliding-window backward support
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant GraphAnalyzer
participant SdpaBwdDsl
participant SM120BackwardKernel
GraphAnalyzer->>SdpaBwdDsl: provide facts.window_left
SdpaBwdDsl->>SM120BackwardKernel: compile window_size_left
SM120BackwardKernel->>SM120BackwardKernel: apply sliding-window score masking
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@cudnn-ci-bot run frost |
|
🚀 Running mirror pipeline Branch: cudnn-gh/pr-505-21f5af3 |
|
What is the percentage of test_mhas_v2.py it supports? |
From the pipeline: |
Before submitting
pre-commit runand committed any formatting changes.cat-*, one or moremod-*, and oneorig-*(see label list).Affected area
Summary
Adds sliding-window attention (SWA) support to the
sdpa_bwd_sm120FROST enginePerf data
Why
Related issues
#381
API and compatibility impact
Testing
Summary by CodeRabbit
New Features
Tests