frost(sdpa): filter arch-specific tests correctly to fix sm120 pipeline failures - #495
frost(sdpa): filter arch-specific tests correctly to fix sm120 pipeline failures#495Aneureka wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughFROST tests now share SM100 and SM103 architecture fixtures. Selected GPU tests also use SM100 and runtime availability markers. ChangesFROST test environment gating
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
9feae2f to
5834856
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@python/cudnn/sdpa/fwd/kernels/prefill_f16_sm120.py`:
- Around line 291-292: Update the initializer containing self.head_tile_qk and
self.head_tile_v to validate both values against SUPPORTED_HEAD_TILES before
deriving any kernel or fragment attributes; reject unsupported widths such as
17, while preserving valid specializations and existing tensor-shape validation.
In `@test/python/sdpa/frost/test_sdpa_graph_analyzer.py`:
- Line 539: Add the `@pytest.mark.L0` decorator to
test_sm120_probe_accepts_mixed_head_dims, preserving the test’s existing
implementation and ensuring the marker is applied directly to this new Python
test.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3c55ddaa-6e97-4404-9abf-a96a9c062b52
📒 Files selected for processing (9)
python/cudnn/sdpa/fwd/api_dsl.pypython/cudnn/sdpa/fwd/kernels/prefill_f16_sm120.pytest/python/gemm/frost/conftest.pytest/python/gemm/frost/test_block_scale_matmul.pytest/python/gemm/frost/test_moe_grouped_block_scale_matmul_fwd.pytest/python/gemm/frost/test_multi_gemm.pytest/python/linear_attention/frost/test_gdn_bprop_kernel.pytest/python/sdpa/frost/test_sdpa_fwd_dsl_sm120.pytest/python/sdpa/frost/test_sdpa_graph_analyzer.py
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@cudnn-ci-bot run frost |
Signed-off-by: Haobin Guo <haobing@nvidia.com>
5834856 to
3048fd3
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@cudnn-ci-bot run frost |
|
🚀 Running mirror pipeline Branch: cudnn-gh/pr-495-3048fd3 |
|
lets just change the CI internally to only run sm120 for spda tests. |
Before submitting
pre-commit runand committed any formatting changes.cat-*, one or moremod-*, and oneorig-*(see label list).Affected area
Summary
Filter architecture-specific tests correctly to fix SM120 pipeline failures.
Why
Currently some tests are intended to run in an SM100 environment (either real or mocked), but are currently executed in the SM120 pipeline and fail as a result. This PR filters out those cases accordingly.
Related issues
Related to #381
API and compatibility impact
N/A.
Testing
Summary by CodeRabbit