Add inference regression test for Reasoner mode.#59
Merged
Conversation
…token logits goldens Adds tests/nano_reasoner_inference_smoke_test.py (mirrors nano_inference_smoke_test style) + tests/_reasoner_logits_probe.py. The probe pins deterministic kernels (greedy decode, CUBLAS_WORKSPACE_CONFIG, FLASH_ATTENTION_DETERMINISTIC=1, cudnn.deterministic) and monkey-patches unified_mot._sample_next_token to dump the first decoded token's logits on rank 0. Two cases, each compared against its own committed golden (exact argmax + allclose rtol/atol=1e-3): text-only (reasoner.json) and image-conditioned (reasoner_image.json). Run-to-run logits are bit-identical on a fixed 4-GPU config (max|Δ|=0.0). Goldens: tests/data/nano_reasoner_inference_smoke_test/first_token_logits_golden.pt tests/data/nano_reasoner_inference_smoke_test/first_token_logits_image_golden.pt Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… goldens) New GPU job runs tests/nano_reasoner_inference_smoke_test.py with TEST_MAX_GPUS=4 (--num-gpus=4 --levels=2), modeled on inference-smoke; caches the image input's remote vision_path via COSMOS_DOWNLOAD_CACHE_DIR. Header comment updated (four -> five GPU jobs). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Target tests/nano_reasoner_inference_smoke_test.py::test_nano_reasoner_image_first_token_logits instead of the whole file; the text-only variant stays in the file but is not exercised in CI. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lfengad
previously approved these changes
Jun 25, 2026
Disambiguates the llava_ov training-loss regression job from the new reasoner-inference-smoke job. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…sion Mirror the reasoner-training-regression rename; consistent *-training-regression naming for the loss-vs-goldens training jobs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Consistent generator-* naming, paralleling reasoner-inference-smoke. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
foreverlms
force-pushed
the
maoshengl/reasoner-inference-test
branch
from
ac07cd5 to
4ea2ebc
Compare
yy-code-nv
approved these changes
Jun 25, 2026
lfengad
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.