Optimize cuda::sub_overflow
#7344
Open
+58
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebayer
force-pushed
the
optimize_sub_overflow_unsigned
branch
from
2db7342 to
c1ba39d
Compare
davebayer
changed the title
cuda::sub_overflow for unsigned typescuda::sub_overflow
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 08m: Pass: 100%/84 | Total: 15h 47m | Max: 43m 08s | Hits: 99%/199232See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes
cuda::sub_overflowimplementation for unsigned types.See the SASS comparison:
Note: I need to find out whether the old implementation wasn't better for signed 32-bit and 64-bit types.