Require is_default_constructible for vectorization of find_if
#7337
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We load into a C-array of InputT, which requires initialization of its elements. Fixes [BUG]: cub/agent/agent_find.cuh, line 106: error: no default constructor exists Fixes NVIDIA#7336
Contributor
😬 CI Workflow Results🟥 Finished in 6h 00m: Pass: 94%/88 | Total: 4d 15h | Max: 6h 00m | Hits: 50%/88419See results here. |
davebayer
reviewed
Jan 24, 2026
| (vector_load_length > 1) && (items_per_thread % vector_load_length == 0) | ||
| && (::cuda::std::contiguous_iterator<InputIteratorT>) && THRUST_NS_QUALIFIER::is_trivially_relocatable_v<InputT>; | ||
| && (::cuda::std::contiguous_iterator<InputIteratorT>) && THRUST_NS_QUALIFIER::is_trivially_relocatable_v<InputT> // | ||
| && ::cuda::std::is_default_constructible_v<InputT>; // We load into an C-array, which requires initialization |
Contributor
There was a problem hiding this comment.
Q: shouldn't we require trivial default constructability?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We load into a C-array of InputT, which requires initialization of its elements.
Fixes [BUG]: cub/agent/agent_find.cuh, line 106: error: no default constructor exists Fixes #7336