Formatters for cuda::arch_id and cuda::compute_capability
#7335
+181
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davebayer
commented
Jan 23, 2026
| assert(std::format(TEST_STRLIT(C, "{}"), cuda::arch_id::sm_103a) == TEST_STRLIT(C, "103a")); | ||
| assert(std::format(TEST_STRLIT(C, "{}"), cuda::arch_id::sm_110a) == TEST_STRLIT(C, "110a")); | ||
| assert(std::format(TEST_STRLIT(C, "{}"), cuda::arch_id::sm_120a) == TEST_STRLIT(C, "120a")); | ||
| assert(std::format(TEST_STRLIT(C, "{}"), cuda::arch_id::sm_121a) == TEST_STRLIT(C, "121a")); |
Contributor
Author
There was a problem hiding this comment.
@bernhardmgruber is formatting cuda::arch_id as "NM[a]" what you want? We could make it "sm_NM[a]", too.
Or alternatively, we can make it part of the formatting options as std::format("{:p}", arch_id) no add the sm_ prefix.
Contributor
Author
There was a problem hiding this comment.
Another option would be:
bfor binary architecture, the output would look assm_NM[a]vfor virtual architecture, the output would look ascompute_NM[a]
Contributor
Author
There was a problem hiding this comment.
Maybe it would be better to keep it as is, you can always prepend the right prefix that works for your compiler.
Contributor
There was a problem hiding this comment.
I would love if it was just spelled like the enum, so sm_103a for example :)
Contributor
😬 CI Workflow Results🟥 Finished in 1h 59m: Pass: 97%/84 | Total: 1d 12h | Max: 1h 59m | Hits: 95%/199098See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR specializes
std::formatterforcuda::arch_idandcuda::compute_capability