Skip to content

fix: comment typo 'mas' -> 'mask' in two TODOs - #3372

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-fused-attn-comment-typo-mas-mask-in-two-todos
Open

fix: comment typo 'mas' -> 'mask' in two TODOs#3372
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:codequality/test-fused-attn-comment-typo-mas-mask-in-two-todos

Conversation

@andrewwhitecdw

Copy link
Copy Markdown
Contributor

This PR fixes a typo in tests/jax/test_fused_attn.py: comment typo 'mas' -> 'mask' in two TODOs.

Changes

  • tests/jax/test_fused_attn.py: comment typo 'mas' -> 'mask' in two TODOs.

Details

--- a/tests/jax/test_fused_attn.py
+++ b/tests/jax/test_fused_attn.py
@@ -1,2 +1,2 @@
-            # TODO(mgoldfarb-nvidia): We will need to add reordering for bias, mas and
-            # THD params once we support those features on CP.
+            # TODO(mgoldfarb-nvidia): We will need to add reordering for bias, mask and
+            # THD params once we support those features on CP.

Tests

Let me know if you want tests added for this fix or not.

Squashed to single commit for review.

Original PR: #6
@github-actions github-actions Bot added the community-contribution PRs from external contributor outside the core maintainers, representing community-driven work. label Aug 13, 2026
@greptile-apps

greptile-apps Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Corrects two instances of “mas” to “mask” in TODO comments within the JAX fused-attention tests.

  • Clarifies that future context-parallel support requires reordering for bias, mask, and THD parameters.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
tests/jax/test_fused_attn.py Corrects two comment-only typos without changing test execution or runtime behavior.

Reviews (2): Last reviewed commit: "fix: comment typo 'mas' -> 'mask' in two..." | Re-trigger Greptile

@cyanguwa

Copy link
Copy Markdown
Collaborator

If the DCO is fixed, I can merge this one quickly without running CI, because it's only changes to the comments. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution PRs from external contributor outside the core maintainers, representing community-driven work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants