Repository navigation
Conversation
Signed-off-by: divesh <dgude@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-5097.docs.buildwithfern.com/openshell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A transparent TCP connection allowed for an IPv4 destination was denied when a dual-stack client used its
::ffff:form. Canonicalize the destination before routing, policy DNS lookup, policy evaluation, and denial reporting, while preserving native IPv6 scope and flow information.Related Issue
Closes #5093
Changes
to_canonical().AF_INET6connection, and document equivalent IPv4 policy matching.Release Notes
Testing
Commands passed:
cargo test --offline -p openshell-supervisor-network --lib proxy::tests::ipv4_mappedcargo test --offline -p openshell-supervisor-network --lib -- staged_ reserved_ metadata_staging --test-threads=1cargo clippy --offline -p openshell-supervisor-network --lib --tests -- -D warningscargo fmt --check -p openshell-supervisor-networkrustfmt --check --edition 2024 e2e/rust/tests/transparent_tcp.rsmise run --skip-tools docs:navThe focused Docker E2E run was canceled after stalling on base-image metadata from
ghcr.io/astral-sh/uvandnvcr.io/nvidia/base/ubuntu, before sandbox tests started. The repository-wide commit hook also failed in unrelated local Python tooling; the commit uses the completed scoped checks above.Checklist