Repository navigation
feat(observability): verify OTLP collectors with a configured CA and client certificate - #5084
Open
krishicks wants to merge 1 commit into
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
🌿 Preview your docs: https://nvidia-preview-pr-5084.docs.buildwithfern.com/openshell |
krishicks
marked this pull request as ready for review
October 30, 2026 22:16
krishicks
force-pushed
the
feat/5080-otlp-collector-tls/krishicks
branch
from
October 30, 2026 23:02
f24def8 to
ffae7cc
Compare
6 of 7 tasks
…client certificate Collectors behind a private CA or requiring mutual TLS were out of reach: gRPC export trusted only the platform roots, OTLP/HTTP and the agent relay refused https endpoints, and nothing could present a client certificate. Each [openshell.gateway.otlp] table now takes ca_file, cert_file, and key_file, inherited with the rest of the collector and read at startup. Every exporter verifies https collectors against that CA and presents the client certificate, over gRPC or HTTP, with HTTP connections built through openshell-crypto. Supervisors receive each distinct material once in their launch bundle, with a 192 KiB total checked at startup so it fits a shared supervisor's launch material, the VM driver receives the file paths, and standalone drivers take --otlp-ca-file, --otlp-cert-file, and --otlp-key-file. Closes #5080 Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicks
force-pushed
the
feat/5080-otlp-collector-tls/krishicks
branch
from
November 2, 2026 15:49
ffae7cc to
37315ba
Compare
6 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Collectors behind a private CA or requiring mutual TLS were out of reach: gRPC export trusted only the platform roots, OTLP/HTTP and the agent relay refused
https://endpoints, and nothing could present a client certificate. Each[openshell.gateway.otlp]table now takesca_file,cert_file, andkey_file, and every exporter verifies against that CA and presents the client certificate.Related Issue
Closes #5080
Changes
ca_file,cert_file, andkey_fileon every OTLP table, inherited with the rest of the collector. They require anhttps://endpoint, are read at startup, are capped at 64 KiB each, and the key must match the certificate.ca_filereplaces the platform roots. Without it,https://collectors are verified against the platform roots, which honorSSL_CERT_FILEandSSL_CERT_DIR.openshell-crypto; gRPC uses tonic's TLS configuration, recorded as dependency-owned in theopenshell-cryptoREADME.https://collectors.--otlp-ca-file,--otlp-cert-file, and--otlp-key-filefor their own spans.e2e/rustandtests/suites/featureslockfiles pick up the TLS dependencies.extraVolumes.Release Notes
OTLP collectors can use a private CA and mutual TLS: set
ca_file, and optionallycert_fileandkey_file, on[openshell.gateway.otlp]or a signal table. The agent trace relay and OTLP/HTTP export now supporthttps://collectors.Testing
cargo fmt --check, and everymise run rust:lintclippy invocation with--lockedopenshell-otel(lib and integration binaries),openshell-core,openshell-server,openshell-gateway, the supervisor binary, and all four compute driversChecklist