[purp]

Summary

The agent launcher applied manifest settings with openshell settings set --global, so launching gator switched proposal_approval_mode to auto for every sandbox on the gateway. This applies manifest settings to the launched sandbox only.

Related Issue

Related to #3469. This PR doesn't close the issue; which PR closes it is still to be decided.

Changes

• scripts/agents/run.sh: removes the gateway-global settings set --global loop. After the sandbox is created, runs openshell settings set <sandbox> <key> <value> for each manifest setting. If a gateway-global value already manages a key, it warns and leaves that value in effect. The launcher never writes global settings.
• scripts/agents/README.md and scripts/agents/gator/README.md: describe settings as sandbox-scoped, with the updated launch order.

Release Notes

Testing

• bash -n and shellcheck on the changed scripts
• scripts/agents/supervisor_test.sh passes
• Pre-commit hook passes
• The same change, rebased onto feat(agents): support Kubernetes Gators with reusable tooling images #4744, worked in a live gator launch: openshell settings get <sandbox> reports agent_policy_proposals_enabled and proposal_approval_mode at sandbox scope, and gateway-global settings are unchanged
• Unit tests added/updated (scripts/agents/run_test.sh is added by feat(agents): support Kubernetes Gators with reusable tooling images #4744; that branch carries the matching test change)
• E2E tests added/updated (if applicable)

Checklist

• Follows Conventional Commits
• Commits are signed off (DCO)

[github-actions]

Compatibility review (advisory)

New or updated breaking changes; see the full report for all findings.

1. configuration — No explicit risk acceptance found

agent.yaml settings changed from required gateway-global writes before launch to best-effort sandbox-only writes after launch.

• Impact: Existing manifests stop configuring other sandboxes, while Gator launched against global disabled/manual settings now continues without its requested policy advisor or automatic approval.
• Action: Preserve existing global, pre-launch settings semantics in v0.1.6 and introduce sandbox-scoped settings through an explicit opt-in with migration guidance.
• PR: fix(agents): apply agent manifest settings per sandbox #4888

Review details

• Execution: complete
• Candidate: PR #4888 (0d05378c22a1acf94b034600d513c8778dbbe77d)
• Baseline: 92434dcb2b6248ac827df05c00551fe7a1fedf17 (92434dcb2b6248ac827df05c00551fe7a1fedf17)
• Reviewed: rust-sdk, python-sdk, go-sdk, typescript-sdk, api-behavior, cli, configuration, policy, helm, state

Advisory review; publication gates are unchanged.

Branch check run

[github-actions]

Label test:e2e applied for 343e963. Open the existing run and click Re-run all jobs to execute with the label set. The run will execute the standard E2E suite after building the required gateway, sandbox, and supervisor images once. The matching required CI gate status on this PR will flip green automatically once the run finishes.

[purp]

gator-agent

PR Review Status

Thanks @purp. I checked your explanation that launching an agent should affect only its own sandbox: the complete diff preserves gateway-global precedence, and the supervisor can pick up settings after launch. The independent code review found no blocking code issues.

Action required: A maintainer must open Branch E2E Checks and select Re-run all jobs now that test:e2e is applied. Also, please add the relevant published docs update under docs/, or explicitly confirm that the launcher README updates are sufficient and published docs are intentionally unnecessary for this settings-scope change.

The E2E Label Help bot confirms that a rerun is needed. The existing run skipped the runtime suites, so its previous success does not establish E2E coverage with the new label. Gator has not been authorized to rerun workflows.

Blocking code findings: None.
Carried findings: None.

Gator metadata

• Validation: Focused agent-launcher bug fix from a verified repository admin; related accepted issue feat(agents): support Kubernetes-driver gateways in the agent launcher #3469 remains open.
• Docs: Launcher READMEs updated; awaiting published docs or an explicit maintainer explanation that they are unnecessary.
• Checks: DCO, Branch Checks, Helm Lint, and Trivy Changes passed on the current head; no merge conflicts.
• E2E: test:e2e applied; current-head mirror is fresh, but runtime suites were skipped before labeling. Maintainer rerun required.
• Head SHA: 343e963a19946c420b8e582cf4d3caa4ed0975b0
• Base SHA: c2311ad01eca37a12abc3ea50446c6487d862ffb
• Merge base SHA: c2311ad01eca37a12abc3ea50446c6487d862ffb
• Patch ID: a0c1aa3b49c5040de7806ba7f57f9b3b30872bbf
• Gator payload: 13
• Review mode: initial
• Previous reviewed SHA: none
• Review budget exhausted: no
• Maintainer decision required: no convergence decision
• Next state: gator:blocked
• Blocked reason: test_dispatch_required

[purp]

gator-agent

PR Review Status

Thanks @purp. I compared your rebased launcher change with the previously reviewed patch and checked its integration with the updated launch path. The independent follow-up review found no new blocking code issues. @johntmyers has approved the current head, and the required E2E suites are now running, which resolves the earlier test-dispatch blocker.

Action required: @purp, add the relevant published docs update under docs/, or provide an explicit maintainer explanation that the launcher README updates are sufficient and published docs are intentionally unnecessary for this settings-scope change.

Blocking code findings: None.

Carried obligation: The published-docs request from the previous review remains open. Maintainer approval without a docs explanation does not resolve that request.

Gator metadata

• Validation: Focused agent-launcher bug fix by a verified repository admin, related to accepted issue feat(agents): support Kubernetes-driver gateways in the agent launcher #3469.
• Docs: Launcher READMEs updated; published docs or an explicit maintainer explanation still required.
• Checks: DCO, Helm Lint, and Trivy Changes passed; Branch Checks pending. No merge conflicts.
• E2E: test:e2e applied; current-head Branch E2E Checks run 41147494856 is in progress with runtime suites executing.
• Approval: Verified maintainer @johntmyers approved the current head.
• Head SHA: c90d1cc880047eb8633776773b31d6783dc8cf20
• Base SHA: 50a3237f229490f2c5cc389922d578ba20b24b33
• Merge base SHA: 50a3237f229490f2c5cc389922d578ba20b24b33
• Patch ID: 39e0a5f92ba990da548096368f81453ba7b121ec
• Gator payload: 13
• Review mode: follow_up
• Previous reviewed SHA: 343e963a19946c420b8e582cf4d3caa4ed0975b0
• Review budget exhausted: no
• Maintainer decision required: no convergence decision
• Next state: gator:in-review