-
Notifications
You must be signed in to change notification settings - Fork 232
Integrate Automated QDQ placement tool - Part 1 #701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
willg-nv
wants to merge
1
commit into
NVIDIA:main
Choose a base branch
from
willg-nv:dev-willg-integrate-auto-qdq-placement-part1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Integrate Automated QDQ placement tool - Part 1 #701
willg-nv
wants to merge
1
commit into
NVIDIA:main
from
willg-nv:dev-willg-integrate-auto-qdq-placement-part1
+3,111
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 17, 2025
longlee0622
reviewed
Dec 17, 2025
9c53783 to
f872e70
Compare
Author
|
Hi @gcunhase, could you help me review this PR? thanks! |
ajrasane
reviewed
Jan 5, 2026
ajrasane
reviewed
Jan 6, 2026
bbbc98b to
80792fa
Compare
Contributor
|
LGTM from my side. Will wait for @gcunhase review. |
gcunhase
reviewed
Jan 8, 2026
gcunhase
reviewed
Jan 8, 2026
gcunhase
reviewed
Jan 8, 2026
gcunhase
reviewed
Jan 8, 2026
Contributor
|
LGTM, added a few comments, thanks. |
Signed-off-by: Will Guo <[email protected]>
80792fa to
66ef3ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: new feature
Overview: This PR integrates an automatical QDQ placment tool into ModelOpt.
This PR is the 1/4 parts of the change, it contains the following changes:
Part 1: #701
Part 2: #702
Part 3: #703
Part 4: #704
Usage
Testing
Implement unit tests, all tests could get passed.
Before your PR is "Ready for review"
Additional Information