FIX: adjust default behavior of cam#37
Open
Thomas A Caswell (tacaswell) wants to merge 1 commit into
Open
Conversation
- remove the image plugin (some IOCs do not have it and we should not be pulling on this from Python anyway) - adjust the default plugin graph we enforce (stats 1-4 should look at roi 1-4)
| self.stats2: self.roi2, | ||
| self.stats3: self.roi3, | ||
| self.stats4: self.roi4, | ||
| self.stats5: self.cam, |
Contributor
There was a problem hiding this comment.
This is probably a result of not understanding what _default_plugin_graph does, but why is stats5 remaining mapped to cam?
There was a problem hiding this comment.
There's usually one more STATS plugin than ROI that will pull statistics for the entire image (while the ROIs are for region of interests i.e. subsections of the whole image.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the image plugin (some IOCs do not have it and we should not be pulling on this from Python anyway)
adjust the default plugin graph we enforce (stats 1-4 should look at roi 1-4)
moving changes from NSLS2/cdi-profile-collection#26 upstream.