Update all attributes in NWM postprocessing outputs to match current v 3.0 products - [NGWPC 11631] - #36
Merged
Conversation
…ding unwanted netcdfs.
…ving time dimension.
…lost from non-gridded output. Added reservoir type attributes
|
I completed the following postprocessing tests using this branch: CONUS: short range, AnA, medium range mem1, long range mem1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes updates to the variable attributes and encoding from templating to combined NWM products. This involves removing xarray generated keys (such as Fill value, chunk sizes) that may conflict with NWM products. The workflow was updated to carry over the NWM attributes right from the templating stage. Other bugs with dimensions of crs variable, feature_ids not adding up in the combined product were also addressed.
Additions
Removals
Changes
reservoir_assimilated_valueto ignored variables list. Added netcdf4 and xarray encoding keys as a list.Testing
Screenshots
Notes
Todos
Checklist
Testing checklist
Target Environment support
Accessibility
Other