Deprecate Forecast Mod (forecastMod.py)

[mdeshotel]

Refactor Forecast Mod.

EDIT by @mxkpp: due to latest priorities, this will not receive a significant refactor, but the initial improvements here are worth merging.

EDIT by @mxkpp: this file forecastMod.py appears to be unused by the current ngen stack. This file will be deprecated by this PR and it will raise a NotImplementedError if another codebase attempts to import it or run it.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Visually tested in supported browsers and devices (see checklist below 👇)
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

• Linux

[mxkpp]

Rebased

[mxkpp]

The changes look fine, they don't appear to affect any business logic, and the tests run fine. Approving after making 2 minor adjustments.

[mxkpp]

I don't see references to the file forecastMod.py or its function process_forecasts anywhere in the current ngen stack. I think it is actually legacy code that is no longer needed. I have updated this PR to deprecate the entire file by raising a NotImplementedError if someone attempts to use it.