Use Projected CRS for Mask Buffering (Instead of Silencing geopandas Warning)

[mdeshotel]

Use projected crs instead of geographic crs for buffering watershed. The new buffer seems reasonable and provides full coverage; see below.

Additions

Removals

Changes

Testing

Screenshots

Notes

Todos

Checklist

• PR has an informative and human-readable title
• Changes are limited to a single goal (no scope creep)
• Code can be automatically merged (no conflicts)
• Code follows project standards (link if applicable)
• Passes all existing automated tests
• Any change in functionality is tested
• New functions are documented (with a description, list of inputs, and expected output)
• Placeholder code is flagged / future todos are captured in comments
• Visually tested in supported browsers and devices (see checklist below 👇)
• Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
• Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

• Linux

[mxkpp]

Questions below

[mxkpp]

Rebased against development

[mxkpp]

This looked mostly good. To cover any of the Hawaiian islands without distortion, I changed Hawaii to dynamically determine the UTM zone of the centroid of the area being modeled and use that UTM projection instead of applying one Hawaii projection. Also increased the buffer to 6km and have it asserting horizontal units of that temporary CRS.

I tested by running CONUS and oCONUS, NWM and AORC and reviewing the output PNG plots. To do that, uncomment this part

if self.mpi_config.rank == 0:
    self.plot_precip(ds)
self.write_sum_tif(self.computed_ds)

And then see the RAINRATE PNGs that come out with this kind of path:

run_ngen/kge_dds/test_bmi/01123000/Output/Calibration_Run/ngen_dr9zi66n_worker/RAINRATE_2013-07-25T01:00:00.000000000_0.png

I think this is ready to merge.

[mxkpp]

@idtodd do you mind reviewing my final commit here? I reviewed the earlier commits already.

[mxkpp]

Note: for Alaska NWM, even though the PNG plot looks okay, the output NetCDF file does not seem to draw in the correct spot in QGIS (it is much too wide, too short, and located above the North Pole). Need to determine if this is an issue with QGIS or if the output NetCDF actually has an issue.

[mxkpp]

Rebased

[mxkpp]

Note: for Alaska NWM, even though the PNG plot looks okay, the output NetCDF file does not seem to draw in the correct spot in QGIS (it is much too wide, too short, and located above the North Pole). Need to determine if this is an issue with QGIS or if the output NetCDF actually has an issue.

I confirmed that the output Alaska NetCDF files draw strangely on the development branch as well, so that is not new behavior with these changes. Good.