Repository navigation
Fail build/publish on build warnings - #415
Merged
Merged
Conversation
This is required to catch things that matter (like if you specify something in _toc.yml but it doesn't exist), but unfortunately it also catches things that don't (like skipping from heading level 1 to 3 without a 2 in between).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
samsrabin
marked this pull request as ready for review
October 15, 2026 16:50
Member
Author
|
Mentioning @nusbaume as requested. Thanks! |
nusbaume
self-requested a review
October 15, 2026 21:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the build-and-publish GitHub Workflow to fail when warnings are generated, the idea being to catch important things like if you mistyped a notebook name in
_toc.yml. It unfortunately also sweeps up some things that I'd consider unimportant, like skipping straight from heading level 1 to 3. As such, this PR also includes fixes to all such warnings. It also includes fixes related to Jupyter Notebook cell IDs, which wouldn't trigger an error but do clog up the log.To avoid unpleasant surprises upon PR merges, this PR also adds a trigger so that a build (not publish) is triggered on PRs.
AI usage: I copied the first few commits' worth of changes from work I did in the CLM-Tutorial repo. I then used Claude to fix all the warnings (and commit the fixes, including writing commit text), confirming myself that they're gone. I wrote this PR text myself.