AOI: move the analyze/cancel popup onto the core popup service

[CarsonDavis]

Category	Lines added	%
Tests	846	74.2%
Production code	294	25.8%

The AOI plugin no longer draws its own analyze/cancel card — it asks core for one and core answers with which button was pressed.

Closes #299

The analyze/cancel card is core's popup now

Previously, you picked an area — searched a state, clicked a boundary in inspect mode, drew a shape, uploaded a file — and a small card appeared above it with the area's name, an Analyze area button and a Cancel button. That card was the plugin's own React component, mounted into a core overlay node through a callback core handed out, and its stylesheet lived in the plugin too.

That arrangement can't survive a real plugin boundary. Handing a plugin a DOM node to mount into means the plugin has to ship a card, its markup and its styling, and every fix to any of it lands in one plugin instead of everywhere.

The fix: AOI sends plain data over the bus — a lat/lng, a title and two button labels — and core draws the card, owns its position and lifecycle, and reports back which button was pressed. Same wording, same buttons, same anchor above the area, plus a close X and Escape handling that the old card never had. Analyze area still emits the same plugin:aoi:analysisAOIReady event with the same feature; core's answer only says which button was pressed, so the plugin attaches the feature itself. The old tooltip component and its styles are deleted, and the contract AOI advertises drops a now-unused cancelled event and a dead subscription to tool switches.

Demo mission: yes, searching any state brings the card up, and it still drives the stats and chart panels.

Closing the card now abandons the selection

Previously, an area you had picked stayed picked until you pressed Analyze area or Cancel. There was no X on the card, Escape did nothing, and clicking somewhere else on the map left the card sitting where it was.

Core reports all three of those — the X, Escape, a click anywhere else on the map — as the same thing: the card was dismissed. The issue asked for the X and the map click but left open what a dismissal should do to the area you had picked.

The fix: a dismissal is treated exactly like Cancel. The area and its highlight are dropped and the same cleared event fires as before. This is the one change a user would notice without drawing anything, and it is the reviewer's call to make.

Demo mission: yes — search a state, then click bare map, and the highlight goes away with the card.

Starting a drawing puts the card away, and backing out brings it back

Previously, with an area selected, clicking Rectangle left the old card up for the whole drawing session, offering to analyze the area you were in the middle of replacing. And because a card is a dialog that takes keyboard focus, it swallowed the Escape and Enter that the drawing session itself needs.

Leaving it up stopped being an option once the card belongs to core: a click on the map during a drawing comes back as a dismissal, which would now wipe the selection out from under you.

The fix: the card is retracted when a drawing starts and the old selection is parked rather than dropped. The first vertex you commit is where it actually goes away. Back out before that vertex — Escape, or a session that ends with no shape — and the same card returns, re-anchored to the middle of the current view so it lands on screen even if you panned. The panel now shows whichever shape the engine reports it started, rather than the button that was pressed, so the two cannot disagree.

Demo mission: yes — search a state, click Rectangle (card goes, highlight stays), press Escape before the first corner (card comes back).

No stray cards, and nobody else's card gets taken down

Previously, selecting a far-away area and closing the tool while the camera was still flying produced a card anyway, with buttons wired to a tool that no longer existed. AOI waits for the camera to settle before asking for a card, and the one-shot camera listener and fallback timer doing that waiting were untracked, so nothing could call them off or stop them both firing. Each deferred show is now a tracked slot that teardown, a newer selection, or a failed camera move all disarm, and only one of them can win it.

Previously, with a card already open, clicking another boundary in inspect mode cleared the selection you had just made — that click reached core a beat later as a dismissal of the still-open card. AOI now retracts its own card before it starts the camera move, so there is nothing left for the click to dismiss.

Core has one popup slot, so a blanket hide on teardown would also take down a card another plugin had put there. Every AOI request travels through the plugin's own bus handle, which stamps it with AOI's id, and core honours a hide request only from the card's owner.

Demo mission: yes for the first two — search a far-off state and close the AOI panel immediately, then click boundary after boundary in inspect mode. No for the third; the demo has no second popup consumer.

A drawn line or point can be a selection

Previously, on a mission whose draw shapes include lines or points, you could draw a line, finish it, and get nothing at all: no card, so the line could neither be analyzed nor cleared. The centroid helper only understood points and polygons and the bounds helper only polygons, so a line fell through both.

The fix: both helpers now walk whatever vertices the geometry has, so a line or point gets the same card, anchored at the mean of its vertices. One consequence to know about: a line wider than the current view now moves the camera, where before it never did.

Demo mission: no. The demo leaves the draw shapes at the polygon, rectangle and circle defaults, and search, boundary clicks and uploads all produce polygons.

Decisions to review

• A drawing session suspends the previous selection, and a cancelled one restores it. The issue put selection behaviour out of scope; the alternatives are to clear the selection outright the moment a drawing starts, or to leave the card up through the session. It matters because the restore path is reachable in ways the issue never describes — leaving Draw mode for Search re-opens the card at the view centre rather than over the area — and because AOI treats any drawing session on the bus as its own, even one another plugin started.
• Dismissing the card clears the selection, the same as Cancel. The live alternative is to keep the area and its highlight after a dismissal, leaving a selection on screen with no controls attached to it. This is the only place today's behaviour changes for someone who never draws, so it wants an explicit yes.
• The card is retracted up front on a new selection rather than guarding the dismissal. Correctness rests on core settling the retracted card before the deferred map click goes looking for a popup to dismiss; the alternatives are to ignore dismissals while a show is pending, or to have core suppress the click that opened a card in the first place. If the ordering assumption breaks, the failure is a selection quietly clearing itself.
• The centroid and bounds helpers were widened from polygons to every geometry. The smaller move was to leave them polygon-only and let lines and points skip the camera step entirely. Two side effects follow: a line selection can now move the camera, and a line boundary now reports a non-zero area, which feeds inspect-layer ordering.
• The label travels as the card's title, in text, not as markup. The live alternative is to send the label inside the card's HTML body instead of as its text title; keeping it as text makes core's rendering the single escaping point for names that come from boundary properties, search entries and uploaded files. The trade is that AOI's safety now rests on core keeping the title text-only.
• AOI keeps no record of whether it has a card open. It asks core to hide blind and trusts the owner check, where the alternative is tracking it locally, which the plugin has the state to do. Any request that went out through the bare global instead of the plugin handle would open a card AOI could never retract.
• plugin:aoi:drawingCancelled is gone from the published contract. Cancel and dismiss both funnel into the cleared event, though core's answer still tells them apart, so the emit could have been kept on the cancel branch. Nothing in the repo listened; an out-of-tree listener loses it silently.
• Hiding the AOI plugin leaves its card on screen; only unloading closes it. There is no hide-scoped teardown signal to hang a retraction on, and the old overlay behaved the same way, so this is unchanged rather than fixed.

[CarsonDavis]

Follow-up carried over from #303's body (trimmed out of it during review):

Overlay retirement — map:addOverlay/removeOverlay are @deprecated in #303 and this PR removes their last plugin consumer (AOI). Full retirement needs its own follow-up issue once these land: MapControl's measure-distance label (merged after these branches were cut) still uses them.

[CarsonDavis]

Superseded by #424, which carries this migration onto the rebuilt stack (#417 → #418 → #419 → #422 → #423 → #424). This branch stays for reference.