Merged
Conversation
|
@MrTJP Is there anything blocking this MR or do you need some help? Currently dealing with this bug and would be happy if it gets fixed 😄 |
Owner
Author
|
Will merge and push tonight, have been away for a while :) |
The renderer in use can't deal with vertices that are not face-aligned to block orientations and thus crashes on the inclines faces of the lever model. Changing the lever model to have straight faces with a sliding lever instead of a gyrating one fixes this crash. Fixes: #1959
29859f2 to
a2a0003
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.