fix(ui): correct usage bar color logic#1411
Open
xbotter wants to merge 4 commits intoMoonshotAI:mainfrom
Open
Conversation
Pass usage ratio (instead of remaining ratio) to _ratio_color. This fixes the inverted color display where high remaining showed red and low remaining showed green. - _format_row: calculate usage_ratio = used / limit - _ratio_color: usage >= 0.9 -> red, >= 0.7 -> yellow, else green Fixes: 50% left showing green, 93% left showing red
c57f34e to
4c9be9d
Compare
- Verify _format_row passes usage ratio (used/limit) to _ratio_color - Test boundary cases: 7%, 50%, 75%, 95% usage - Test zero limit handling
Add boundary tests for 0%, 69%, 70%, 89%, 90%, 100% usage ratios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass usage ratio (instead of remaining ratio) to _ratio_color. This fixes the inverted color display where high remaining showed red and low remaining showed green.
Fixes: 50% left showing green, 93% left showing red
Related Issue
Resolve N/A
Description
Checklist
make gen-changelogto update the changelog.make gen-docsto update the user documentation.