feat(acp): skip Kimi auth check for non-kimi providers#1347
Open
bu6n wants to merge 3 commits intoMoonshotAI:mainfrom
Open
feat(acp): skip Kimi auth check for non-kimi providers#1347bu6n wants to merge 3 commits intoMoonshotAI:mainfrom
bu6n wants to merge 3 commits intoMoonshotAI:mainfrom
Conversation
f132a51 to
b180edf
Compare
This was referenced Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_check_authmethod previously always required Kimi OAuth authentication, even when the configured default model used a non-Kimi provider."kimi", the auth check is skipped entirely.Motivation
Enables using
kimi-clias an ACP server in editors like Zed with a custom provider (e.g., OpenAI-compatible, Anthropic, etc.) without hitting anAUTH_REQUIREDerror from the Kimi OAuth flow.How it works
"kimi", return early from_check_auth.Testing
~/.kimi/config.toml.AUTH_REQUIREDerror is raised and completions work as expected.