Repository navigation
Conversation
Contributor
|
looks mostly reasonable. I'm curious at what your set up is that is causing it to fail, though. I do search through $PATH. I do this manually, for some reason (I think because pg_config can be in a separate place the pg_ctl?). Where are your your pg_config and pg_ctl located, and what does "pg_config --bindir" show? |
Author
I can remove that part if you want. I think setting the env is really what fix my issue, but checking the path is something I tried first and didn't think it would hurt to leave it. |
Author
|
@bennybp would you prefer I remove the |
2 tasks done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL Snowflake Startup Changes
Functional Improvement: Prefer
pg_ctlfound directly onPATHbefore falling back topg_config-based discovery inPostgresHarness.pg_configfrom one installation andpg_ctl/postgresfrom another), which can cause fragile startup behavior after package manager upgrades.Debugging Enhancement: Include PostgreSQL logfile path and log tail in startup failures raised by
PostgresHarness.start().pg_ctloften returns generic errors like "could not start server"; surfacing log tail makes root-cause diagnosis immediate without manual file hunting.Functional Improvement: Add targeted detection of locale-related PostgreSQL startup failure and retry
pg_ctl startonce withLC_ALL=CandLANG=C.LC_ALL), which can trigger PostgreSQL startup aborts; retrying only on known failure signatures avoids broad environment changes.Functional Improvement: Add a PostgreSQL minimum version check in
qcfractal/db_socket/socket.pybefore creating tables and running Alembic upgrades.NULLS NOT DISTINCTbehavior in unique constraints); failing early with a clear message avoids hard-to-diagnose migration/runtime failures later.Debugging Enhancement: Add explicit retry note text to the raised startup error when locale-safe retry was attempted.
Close #1000
Status