Fix battle move animations not firing from buttons; add post-attack pause - #12
Merged
Merged
Conversation
Co-authored-by: MobyNL <59473010+MobyNL@users.noreply.github.com>
Copilot stopped work on behalf of
MobyNL due to an error
March 12, 2026 14:47
…move duplicate catch message Co-authored-by: MobyNL <59473010+MobyNL@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Integrate async animation system into Pokemon gameplay
Integrate async animation system into key Pokemon gameplay moments
Mar 12, 2026
Co-authored-by: MobyNL <59473010+MobyNL@users.noreply.github.com>
Copilot
AI
changed the title
Integrate async animation system into key Pokemon gameplay moments
Fix battle move animations not firing from buttons; add post-attack pause
Mar 12, 2026
MobyNL
marked this pull request as ready for review
March 12, 2026 20:15
Owner
|
@copilot not all unit tests pass. Please fix the issues, or update the unit tests if we updated our code |
Co-authored-by: MobyNL <59473010+MobyNL@users.noreply.github.com>
Author
Fixed in fa38c86. The 33 failing tests were all async tests in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on_button_pressedmadeasyncinterminal.py; move-button calls nowawait self.execute_player_move(...)— coroutine was silently dropped beforeawait simple_delay(0.5)added after opponent's turn inexecute_player_movepytest-asyncioto thepip installstep inci.yml— it was missing, causing all 33 async tests intest_text_animation.pyto fail with "async def functions are not natively supported"💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.