Skip to content

Fix battle move animations not firing from buttons; add post-attack pause - #12

Merged
MobyNL merged 5 commits into
integrate-animationsfrom
copilot/integrate-animation-system
Mar 12, 2026
Merged

Fix battle move animations not firing from buttons; add post-attack pause#12
MobyNL merged 5 commits into
integrate-animationsfrom
copilot/integrate-animation-system

Conversation

Copilot AI commented Mar 12, 2026

Copy link
Copy Markdown
  • Fix: on_button_pressed made async in terminal.py; move-button calls now await self.execute_player_move(...) — coroutine was silently dropped before
  • Fix: await simple_delay(0.5) added after opponent's turn in execute_player_move
  • Fix CI: add pytest-asyncio to the pip install step in ci.yml — it was missing, causing all 33 async tests in test_text_animation.py to fail with "async def functions are not natively supported"
  • All 1725 tests pass locally

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: MobyNL <59473010+MobyNL@users.noreply.github.com>
…move duplicate catch message

Co-authored-by: MobyNL <59473010+MobyNL@users.noreply.github.com>
Copilot AI changed the title [WIP] Integrate async animation system into Pokemon gameplay Integrate async animation system into key Pokemon gameplay moments Mar 12, 2026
Copilot AI requested a review from MobyNL March 12, 2026 19:38
Co-authored-by: MobyNL <59473010+MobyNL@users.noreply.github.com>
Copilot AI changed the title Integrate async animation system into key Pokemon gameplay moments Fix battle move animations not firing from buttons; add post-attack pause Mar 12, 2026
@MobyNL
MobyNL marked this pull request as ready for review March 12, 2026 20:15
@MobyNL

MobyNL commented Mar 12, 2026

Copy link
Copy Markdown
Owner

@copilot not all unit tests pass. Please fix the issues, or update the unit tests if we updated our code

Co-authored-by: MobyNL <59473010+MobyNL@users.noreply.github.com>

Copilot AI commented Mar 12, 2026

Copy link
Copy Markdown
Author

@copilot not all unit tests pass. Please fix the issues, or update the unit tests if we updated our code

Fixed in fa38c86. The 33 failing tests were all async tests in test_text_animation.pypytest-asyncio was missing from the CI pip install command in ci.yml, so the asyncio_mode = "auto" setting in pyproject.toml had no effect. Added pytest-asyncio to the install step. All 1725 tests now pass.

@MobyNL
MobyNL merged commit 1299dc6 into integrate-animations Mar 12, 2026
@MobyNL
MobyNL deleted the copilot/integrate-animation-system branch March 12, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants