WebView: revert background-colour patches (experimental)#31
Closed
jakepenn wants to merge 4 commits into
Closed
Conversation
Member
Author
|
Reverting isn't the right path — adding a targeted viewDidChangeBackingProperties override on top of the existing patches instead. New PR incoming. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the four Minimal patches that customise WebView background painting on macOS/iOS and Windows. Purpose: validate whether the white-flash fixes were actually necessary, and isolate them as the cause of monitor-dependent pixelation we're now seeing in the Memory Rites player on macOS (high-DPI WKWebView content rasterising at 1x when the host window moves between displays with different
+ "backingScaleFactor" +).Reverts, newest first:
+ "a8b2868" +— WebView (Windows): suppress background flash on creation and hide/show+ "fe88d6d" +— WebView (Windows): pre-seed renderer background colour via CLI switch+ "5575dec" +— WebView (macOS/iOS): set drawsBackground on WebView, not config+ "bdddb16" +— WebView (macOS/iOS): expose AppleWkWebView::withBackgroundColourExpected consequences
+ "AppleWkWebView::withBackgroundColour" +/+ "getBackgroundColour" +are removed by the+ "bdddb16" +revert. Any caller in+ "minimal_core" +will fail to compile until updated — there's one call site in+ "lib/managers/web_bridge/MKUEmbeddedWebView.cpp" +that needs to be dropped in a follow-up commit alongside the submodule bump.Test plan
+ "viewDidChangeBackingProperties" +override on the WKWebView subclass to keep+ "layer.contentsScale" +in sync with the window's backing factor)🤖 Generated with Claude Code