fix: preserve cancelled run terminal events - #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cancelled run could later record
run.failedorrun.completedwhen its connector finished, leaving contradictory lifecycle history. Ignore those late terminal records once cancellation is persisted, and serialize the status check with cancellation. Diagnostic events and existing history remain available.Scope: run event persistence only. No API, streaming, retry, or authorization changes.
Validation:
make sqlc-generate,make check, and isolated PostgreSQL regression tests for both terminal event types, active/cancelled runs, preserved diagnostics and sequence numbers, unknown runs, and concurrent status-update locking. A fresh independent review found no actionable issues. Local Docker remained stopped; database tests used a separate remote test database.