fix(server): reject CLI options in Skill install references - #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill installation accepted option-shaped slugs and source strings that the upstream CLI could interpret as local paths. Reject those values before invoking the downloader, while preserving ordinary owner/repo references and safe Skill names.
Scope: input validation only; installation, credentials, permissions and persistence are unchanged.
Validation: the new route tests fail against the baseline because the runner is invoked, then pass with the guard; safe-reference cases pass.
make checkpassed and OpenAPI regeneration produced no changes. Tests use a fake downloader and do not execute the unsafe CLI arguments.