fix(gateway): acknowledge Feishu reaction notifications - #418
Merged
Conversation
SaladDay
marked this pull request as ready for review
September 10, 2026 04:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feishu emits reaction-created and reaction-deleted notifications during ordinary bot use, including Parsar’s typing indicator. The WebSocket dispatcher currently reports these as missing-handler errors. Acknowledge those notifications without starting work or changing send/undo reaction state.
Keep event registration in a small helper outside the oversized manager file. Existing message and card handlers retain their behavior, and unsupported event types and malformed payloads continue to fail.
Validation: native SDK dispatch tests cover both reaction events, unsupported and malformed events, and the existing message/card routes.
make checkpassed; local Docker migration smoke testing was skipped because Docker is unavailable.