Repository navigation
status: resolve failures of attributes a rebuild no longer has - #265
Merged
Merged
Conversation
A rebuild of the same commit without an attribute, e.g. after the PR's base dropped it, left that attribute's failed status on the commit forever (#262). When a build reports its whole attribute set, mark the stored failures it does not cover as resolved. Change-Id: I1390a3f0ae0a7092d6667b716a6c458a49a81a7e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #262.
A rebuild of the same commit that no longer has a failed attribute, e.g. after the PR's base dropped it, now marks that failure as resolved instead of leaving it red.