Skip to content

chore: bump anchor v1#51

Merged
codewithgun merged 4 commits into
release_0.2.2from
bump-anchor-v1
May 19, 2026
Merged

chore: bump anchor v1#51
codewithgun merged 4 commits into
release_0.2.2from
bump-anchor-v1

Conversation

@codewithgun
Copy link
Copy Markdown
Contributor

@codewithgun codewithgun commented Apr 23, 2026

Changes

  • Upgrade to anchor v1
  • Use only bun as package manager + runtime for test instead of combined package manager such as pnpm + yarn. bun is more memory efficient

TODO

  • Close existing IDL account before deployment because the IDL account update will no longer in the program itself.
  1. Close existing IDL account before deployment
  2. Deploy anchor v1.0.0 program
  3. anchor idl init
    https://github.com/solana-foundation/anchor/blob/7b108db7987afedd1e72edd783d7fc00416e213f/docs/content/docs/updates/release-notes/1-0-0.mdx#legacy-idl-instructions-replaced-by-program-metadata

Program metadata: https://github.com/solana-program/program-metadata

@codewithgun
Copy link
Copy Markdown
Contributor Author

/bot review

@metoeraag-bot
Copy link
Copy Markdown

metoeraag-bot Bot commented Apr 27, 2026

Bot Agent progress: /bot review

Progress:

  • Repo checks (5 ok, 1 failed)
  • Context build
  • Codex review (1 pass)
  • Parallel review (Claude (API) + Codex merged)
  • Post review

Copy link
Copy Markdown

@metoeraag-bot metoeraag-bot Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

Request changes

Summary

⚠️ Limited-confidence review: check failed: cargo clippy --workspace --all-targets -- -D warnings.

Posted 2 validated inline finding(s) after final filtering.

Findings
  • [P1] Cargo.toml:15 With this Anchor v1 bump, cargo clippy --workspace --all-targets -- -D warnings now fails: declare_program!(jupiter) in libs/jupiter/src/lib.rs:3 triggers clippy::too_many_arguments from the generated code. Please add a targeted allow around that macro/crate, or otherwise make clippy pass, before merging.
  • [P3] README.md:32 bun run test no longer builds the program/IDL, while the tests load files from target/idl/target/deploy and target is gitignored. On a clean checkout this command will fail unless bun run build-local ran first; consider documenting bun run build-local-test here or adding the build step back to test.
Repo checks

Repo Checks

  • rustup component add --toolchain 1.93.0-x86_64-unknown-linux-gnu rustfmt: ok
info: component rustfmt is up to date
  • rustup component add --toolchain 1.93.0-x86_64-unknown-linux-gnu clippy: ok
info: component clippy is up to date
  • cargo fetch --locked: ok
Updating git repository `https://github.com/MeteoraAg/damm-v2`
From https://github.com/MeteoraAg/damm-v2
 * [new ref]         c918cb8023dc01cb01a84c322bb94128cd0abfc8 -> refs/commit/c918cb8023dc01cb01a84c322bb94128cd0abfc8
  • cargo check --workspace: ok
stem-interface v2.0.0
    Checking solana-last-restart-slot v3.0.0
    Checking solana-slot-hashes v3.0.1
    Checking solana-slot-history v3.0.0
    Checking solana-epoch-schedule v3.1.0
    Checking solana-instructions-sysvar v3.0.0
    Checking solana-clock v3.0.1
    Checking solana-epoch-rewards v3.0.1
    Checking solana-rent v3.1.0
    Checking solana-zk-sdk v4.0.0
    Checking solana-cpi v3.1.0
    Checking solana-stable-layout v3.0.1
    Checking solana-system-interface v3.2.0
    Checking spl-type-length-value v0.9.1
    Checking solana-sysvar v3.1.1
    Checking spl-token-group-interface v0.7.2
    Checking solana-invoke v0.5.0
    Checking spl-token-interface v2.0.0
    Checking spl-associated-token-account-interface v2.0.0
    Checking solana-stake-interface v2.0.2
    Checking solana-loader-v3-interface v6.1.1
    Checking spl-pod v0.7.3
    Checking spl-token-confidential-transfer-proof-generation v0.5.1
    Checking spl-token-metadata-interface v0.8.0
    Checking spl-token-confidential-transfer-proof-extraction v0.5.1
   Compiling anchor-derive-serde v1.0.1
   Compiling anchor-attribute-program v1.0.1
   Compiling anchor-attribute-event v1.0.1
   Compiling anchor-attribute-error v1.0.1
   Compiling anchor-derive-accounts v1.0.1
   Compiling anchor-attribute-account v1.0.1
   Compiling anchor-attribute-constant v1.0.1
    Checking spl-token-2022-interface v2.1.0
    Checking anchor-lang v1.0.1
    Checking jupiter v0.1.0 (/data/workdir/2962945/MeteoraAg/zap-program/libs/jupiter)
    Checking anchor-spl v1.0.1
    Checking dlmm v0.10.1 (/data/workdir/2962945/MeteoraAg/zap-program/libs/dlmm)
    Checking protocol-zap v0.1.0 (/data/workdir/2962945/MeteoraAg/zap-program/protocol-zap)
    Checking cp-amm v0.2.1 (https://github.com/MeteoraAg/damm-v2?rev=c918cb8023dc01cb01a84c322bb94128cd0abfc8#c918cb80)
    Checking zap v0.2.2 (/data/workdir/2962945/MeteoraAg/zap-program/programs/zap)
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.04s
  • cargo fmt --check: ok
  • cargo clippy --workspace --all-targets -- -D warnings: failed
Checking jupiter v0.1.0 (/data/workdir/2962945/MeteoraAg/zap-program/libs/jupiter)
    Checking zap-sdk v0.1.0 (/data/workdir/2962945/MeteoraAg/zap-program/zap-sdk)
    Checking dlmm v0.10.1 (/data/workdir/2962945/MeteoraAg/zap-program/libs/dlmm)
error: this function has too many arguments (8/7)
 --> libs/jupiter/src/lib.rs:3:1
  |
3 | declare_program!(jupiter);
  | ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_arguments
  = note: `-D clippy::too-many-arguments` implied by `-D warnings`
  = help: to override `-D warnings` add `#[allow(clippy::too_many_arguments)]`
  = note: this error originates in the macro `declare_program` (in Nightly builds, run with -Z macro-backtrace for more info)

error: this function has too many arguments (8/7)
 --> libs/jupiter/src/lib.rs:3:1
  |
3 | declare_program!(jupiter);
  | ^^^^^^^^^^^^^^^^^^^^^^^^^
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_arguments
  = note: this error originates in the macro `declare_program` (in Nightly builds, run with -Z macro-backtrace for more info)

error: could not compile `jupiter` (lib) due to 2 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `jupiter` (lib test) due to 2 previous errors

Comment thread Cargo.toml Outdated
Comment thread README.md Outdated
Comment thread programs/zap/Cargo.toml Outdated
Comment thread package.json Outdated
@codewithgun codewithgun merged commit f22293b into release_0.2.2 May 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants