Skip to content

Conversation

@lsabor
Copy link
Contributor

@lsabor lsabor commented Feb 8, 2026

Fixes #3592

Changes

  • Move "Group Variable" field below "Categories" and above "Subquestions" in group question editor
  • Move time fields (Close Time, Resolving Time, Open Time, CP Reveal Time) below NumericQuestionInput in continuous question editor

The field ordering now matches the requested layout as shown in the issue screenshots.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor
    • Reorganized form field ordering to streamline form layouts
    • Consolidated advanced input options into a dedicated section for improved form structure and accessibility

- Move "Group Variable" field below "Categories" and above "Subquestions" in group question editor
- Move time fields (Close Time, Resolving Time, Open Time, CP Reveal Time) below NumericQuestionInput in continuous question editor

Co-authored-by: Luke Sabor <lsabor@users.noreply.github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

📝 Walkthrough

Walkthrough

Form fields in question and group editors are reordered per user request. The group variable field is repositioned below categories, and time-related date inputs are moved into a new Advanced Options section within the question form.

Changes

Cohort / File(s) Summary
Group Question Form Reordering
front_end/src/app/(main)/questions/components/group_form.tsx
Moved group_variable input block from above resolution criteria to after the categories section; props and validation logic unchanged.
Continuous Question Form Reordering
front_end/src/app/(main)/questions/components/question_form.tsx
Repositioned NumericQuestionInput block and moved open_time and cp_reveal_time DateInput components into a new Advanced Options section below the graph; layout blocks adjusted to accommodate new field placement.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Fields hop to their rightful place,
Variables dance in their new space,
Times tucked below in advanced care,
Reorganized with bunny flair!
Form flows better, logic stays true,
Reordering complete, just as requested, thank you! 🎉

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Reorder fields in question creation forms' accurately and concisely summarizes the main change: reordering form fields in question editors.
Linked Issues check ✅ Passed The PR successfully addresses issue #3592 by moving Group variable below Categories in group_form.tsx and moving time fields below NumericQuestionInput in question_form.tsx, matching the requested layout.
Out of Scope Changes check ✅ Passed All changes are directly aligned with issue #3592 requirements; no out-of-scope modifications to validation logic, data handling, or unrelated functionality are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/issue-3592-20260208-2305

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lsabor lsabor requested a review from ncarazon February 8, 2026 23:14
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@front_end/src/app/`(main)/questions/components/question_form.tsx:
- Around line 889-916: The InputContainer for Open Time uses a hardcoded English
explanation string; replace explanation={"When this question will be open for
predictions."} with a translation call (e.g.
explanation={t("openTimeDescription")} or another appropriate i18n key) so it
uses the existing t(...) pattern; update the translation files to add the chosen
key if missing and keep the reference in the InputContainer props (look for the
InputContainer instance that wraps DateInput with name="open_time").

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2026

🧹 Preview Environment Cleaned Up

The preview environment for this PR has been destroyed.

Resource Status
🌐 Preview App ✅ Deleted
🗄️ PostgreSQL Branch ✅ Deleted
⚡ Redis Database ✅ Deleted
🔧 GitHub Deployments ✅ Removed
📦 Docker Image ⚠️ Retained (auto-cleanup via GHCR policies)

Cleanup triggered by PR close at 2026-02-09T15:56:48Z

Copy link
Contributor

@ncarazon ncarazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lsabor lsabor merged commit dd8ee4d into main Feb 9, 2026
11 of 12 checks passed
@lsabor lsabor deleted the claude/issue-3592-20260208-2305 branch February 9, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reorder some fields in question creation

2 participants