feat!: Expose Accounts-owned controller/service methods through messenger by GuillaumeRx · Pull Request #7976 · MetaMask/core

GuillaumeRx · 2026-02-18T11:14:53Z

Explanation

Exposes all the public methods other than init or any internally used methods of the accounts-owned controllers/services throught the messenger.

This also refactors how actions are defined and bound to the messenger using registerMethodActionHandlers and MESSENGER_EXPOSED_METHODS.

The generate-method-action-type script was used to generate the action types.

This is a breaking change in the profile-sync-controller package as some of the action type names changed but none of the underlying signatures changed.

References

Checklist

I've updated the test suite for new or updated code as appropriate
I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
I've communicated my changes to consumers by updating changelogs for packages I've changed
I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Wide cross-package refactor of messenger action registration and exported action type names; risk is mainly integration breakage for consumers relying on old action types or missing exposed methods, rather than new business logic.

Overview
Refactors AccountsController, AccountTreeController, MultichainAccountService, and profile-sync-controller (AuthenticationController, UserStorageController) to expose public APIs through the messenger via registerMethodActionHandlers and per-module MESSENGER_EXPOSED_METHODS, replacing manual registerActionHandler wiring.

Introduces auto-generated *-method-action-types.ts files (and new generate-method-action-types scripts using tsx) and updates package exports/types and cross-package AllowedActions references to the new ...Action type names (notably a breaking rename in profile-sync-controller). Tests were adjusted for the new action names and a couple of behaviors (e.g., selected-account missing ID now throws; account-group name conflict resolution is exercised via public setters).

^{Written by Cursor Bugbot for commit 7ec9ffb. This will update automatically on new commits. Configure here.}

GuillaumeRx · 2026-02-18T11:16:15Z

packages/account-tree-controller/src/AccountTreeController.test.ts

+      controller.setAccountGroupName(groupId, 'Suffix Test', true);

-      // Test with no conflicts: should return "Unique Name (2)"
-      const uniqueName = controller.resolveNameConflict(
-        wallet,
-        groupId,
-        'Unique Name',
-      );
-      expect(uniqueName).toBe('Unique Name (2)');
+      const collidingGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(collidingGroupObject?.metadata.name).toBe('Suffix Test (3)');
+
+      // Test with no conflicts: should return "Unique Name"
+      controller.setAccountGroupName(groupId, 'Unique Name', true);
+
+      const uniqueGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(uniqueGroupObject?.metadata.name).toBe('Unique Name');


resolveNameConflict is only internally used. It doesn't make sense to have it publicly only to test its behavior in unit tests. We can do that via the public methods that uses it

I can confirm this is not used in either extension and mobile.

GuillaumeRx · 2026-02-18T11:17:30Z

packages/account-tree-controller/src/AccountTreeController.test.ts

+      controller.setAccountGroupName(groupId, 'Suffix Test', true);

-      // Test with no conflicts: should return "Unique Name (2)"
-      const uniqueName = controller.resolveNameConflict(
-        wallet,
-        groupId,
-        'Unique Name',
-      );
-      expect(uniqueName).toBe('Unique Name (2)');
+      const collidingGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(collidingGroupObject?.metadata.name).toBe('Suffix Test (3)');
+
+      // Test with no conflicts: should return "Unique Name"
+      controller.setAccountGroupName(groupId, 'Unique Name', true);
+
+      const uniqueGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(uniqueGroupObject?.metadata.name).toBe('Unique Name');


This assertion was very misleading by the way. If there's no conflict the method shouldn't be called therefore no suffix should be added.

GuillaumeRx · 2026-02-18T11:18:28Z

packages/accounts-controller/src/AccountsController.ts

   * @throws An error if the account ID is not found.
   */
-  getAccountExpect(accountId: string): InternalAccount {
+  #getAccountExpect(accountId: string): InternalAccount {


We don't need this method to be public, it's only used internally.

Makes sense!

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

packages/account-tree-controller/src/types.ts

packages/profile-sync-controller/src/controllers/authentication/AuthenticationController.ts

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts

GuillaumeRx · 2026-02-19T15:14:58Z

packages/profile-sync-controller/src/controllers/authentication/index.ts

I don't know what's going on here with the imports, I just made sure that the original export behavior was respected.

This certainly seems cleaner :)

GuillaumeRx · 2026-02-19T15:15:18Z

packages/profile-sync-controller/src/controllers/user-storage/index.ts

I don't know what's going on here with the imports, I just made sure that the original export behavior was respected.

packages/account-tree-controller/src/types.ts

GuillaumeRx · 2026-02-20T13:01:05Z

packages/multichain-account-service/src/MultichainAccountService.test.ts

+      const { messenger, mocks } = await setup({
        accounts: [MOCK_HD_ACCOUNT_1],
      });

-      const resyncAccountsSpy = jest.spyOn(service, 'resyncAccounts');
      await messenger.call('MultichainAccountService:resyncAccounts');
-      expect(resyncAccountsSpy).toHaveBeenCalled();
+
+      expect(mocks.EvmAccountProvider.resyncAccounts).toHaveBeenCalled();
+      expect(mocks.SolAccountProvider.resyncAccounts).toHaveBeenCalled();


we can't spy resyncAccounts at this step since registeMethodActionHandlers will register the original method not the spied one

GuillaumeRx · 2026-02-20T13:01:33Z

packages/multichain-account-service/src/MultichainAccountService.test.ts

-      const ensureCanUseSnapPlatformSpy = jest.spyOn(
-        service,
-        'ensureCanUseSnapPlatform',
+      await rootMessenger.call(
+        'MultichainAccountService:ensureCanUseSnapPlatform',
      );
-      await messenger.call('MultichainAccountService:ensureCanUseSnapPlatform');
-      expect(ensureCanUseSnapPlatformSpy).toHaveBeenCalled();


we can't spy ensureCanUseSnapPlatform at this step since registeMethodActionHandlers will register the original method not the spied one

…StorageController`

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

packages/multichain-account-service/src/MultichainAccountService.test.ts

mcmire

Nice! The code changes themselves look good, but I had some suggestions on changelogs. (You may need to add the no-changelog label to this PR to suppress the changelog checker.)

mcmire · 2026-02-20T15:09:18Z

packages/account-tree-controller/src/AccountTreeController.test.ts

+      controller.setAccountGroupName(groupId, 'Suffix Test', true);

-      // Test with no conflicts: should return "Unique Name (2)"
-      const uniqueName = controller.resolveNameConflict(
-        wallet,
-        groupId,
-        'Unique Name',
-      );
-      expect(uniqueName).toBe('Unique Name (2)');
+      const collidingGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(collidingGroupObject?.metadata.name).toBe('Suffix Test (3)');
+
+      // Test with no conflicts: should return "Unique Name"
+      controller.setAccountGroupName(groupId, 'Unique Name', true);
+
+      const uniqueGroupObject = controller.getAccountGroupObject(groupId);
+
+      expect(uniqueGroupObject?.metadata.name).toBe('Unique Name');


I can confirm this is not used in either extension and mobile.

mcmire · 2026-02-20T15:16:25Z

packages/account-tree-controller/CHANGELOG.md

+  - The controller's methods are now exposed to the messenger through `registerMethodActionHandlers` and `MESSENGER_EXPOSED_METHODS`.
+  - The action types are now generated using `generate-method-action-types`.
+  - Exposes the missing public methods in the messenger.
+- Update `UserStorageController` and `AuthenticationController` actions to their new names ([#7976](https://github.com/MetaMask/core/pull/7976))


Are these public-facing changes? It looks like we are using new names for the types in the union, but neither the names of the action type strings nor the signatures of the action handlers themselves have changed. So consumers should not need to adjust how they construct the AccountTreeController messenger. Is this true?

Suggested change

- Update `UserStorageController` and `AuthenticationController` actions to their new names ([#7976](https://github.com/MetaMask/core/pull/7976))

mcmire · 2026-02-20T15:19:05Z

packages/accounts-controller/src/AccountsController.ts

   * @throws An error if the account ID is not found.
   */
-  getAccountExpect(accountId: string): InternalAccount {
+  #getAccountExpect(accountId: string): InternalAccount {


Makes sense!

mcmire · 2026-02-20T15:20:27Z

packages/account-tree-controller/CHANGELOG.md

+  - The action types are now generated using `generate-method-action-types`.
+  - Exposes the missing public methods in the messenger.
+- Update `UserStorageController` and `AuthenticationController` actions to their new names ([#7976](https://github.com/MetaMask/core/pull/7976))
 - Bump `@metamask/accounts-controller` from `^36.0.0` to `^36.0.1` ([#7996](https://github.com/MetaMask/core/pull/7996))


Should we mention that we effectively removed resolveNameConflict?

Suggested change

- Bump `@metamask/accounts-controller` from `^36.0.0` to `^36.0.1` ([#7996](https://github.com/MetaMask/core/pull/7996))

### Removed

- **BREAKING:** Remove `resolveNameConflict` from `AccountTreeController` ([#7976](https://github.com/MetaMask/core/pull/7976))

- This method was only used internally.

mcmire · 2026-02-20T15:27:10Z

packages/account-tree-controller/CHANGELOG.md

 ### Changed

+- Refactor the controller's messenger action registration ([#7976](https://github.com/MetaMask/core/pull/7976/))
+  - The controller's methods are now exposed to the messenger through `registerMethodActionHandlers` and `MESSENGER_EXPOSED_METHODS`.
+  - The action types are now generated using `generate-method-action-types`.
+  - Exposes the missing public methods in the messenger.


We've been keeping changelog entries focused on public changes to the API only.
Curious if instead of highlighting that we refactored the messenger action registration, we should instead call out which methods are now available through the messenger? Also should this be in "Added" since we are adding new things that consumers can use?

Suggested change

### Changed

- Refactor the controller's messenger action registration ([#7976](https://github.com/MetaMask/core/pull/7976/))

- The controller's methods are now exposed to the messenger through `registerMethodActionHandlers` and `MESSENGER_EXPOSED_METHODS`.

- The action types are now generated using `generate-method-action-types`.

- Exposes the missing public methods in the messenger.

### Added

- Expose missing public `AccountTreeController` methods through its messenger ([#7976](https://github.com/MetaMask/core/pull/7976/))

- The following actions are now available:

- `AccountTreeController:getAccountWalletObject`

- `AccountTreeController:getAccountWalletObjects`

- `AccountTreeController:getAccountGroupObject`

- `AccountTreeController:clearState`

- `AccountTreeController:syncWithUserStorage`

- `AccountTreeController:syncWithUserStorageAtLeastOnce`

- Corresponding action types (e.g. `AccountTreeControllerGetAccountWalletObjectAction`) are available as well.

mcmire · 2026-02-20T15:58:07Z

packages/multichain-account-service/CHANGELOG.md


 ### Changed

+- Refactor the controller's messenger action registration ([#7976](https://github.com/MetaMask/core/pull/7976/))


(Similar as for the changelogs above)

mcmire · 2026-02-20T15:59:17Z

packages/notification-services-controller/CHANGELOG.md

 - Debounce `KeyringController:stateChange` handler to reduce redundant notification subscription calls during rapid account syncing ([#7980](https://github.com/MetaMask/core/pull/7980))
 - Filter out Product Account announcements notifications older than 3 months ([#7884](https://github.com/MetaMask/core/pull/7884))
 - Bump `@metamask/controller-utils` from `^11.18.0` to `^11.19.0` ([#7995](https://github.com/MetaMask/core/pull/7995))
+- Update `AuthenticationController` actions to their new names ([#7976](https://github.com/MetaMask/core/pull/7976))


Suggested change

- Update `AuthenticationController` actions to their new names ([#7976](https://github.com/MetaMask/core/pull/7976))

mcmire · 2026-02-20T15:59:24Z

packages/profile-metrics-controller/CHANGELOG.md


 ### Changed

+- Update `AuthenticationController` action to its new name ([#7976](https://github.com/MetaMask/core/pull/7976))


Suggested change

- Update `AuthenticationController` action to its new name ([#7976](https://github.com/MetaMask/core/pull/7976))

mcmire · 2026-02-20T16:30:43Z

packages/profile-sync-controller/CHANGELOG.md

+- **BREAKING:** Refactor the controller's messenger action registration ([#7976](https://github.com/MetaMask/core/pull/7976/))
+  - The controller's methods are now exposed to the messenger through `registerMethodActionHandlers` and `MESSENGER_EXPOSED_METHODS`.
+  - The action types are now generated using `generate-method-action-types`.
+  - Exposes the missing public methods in the messenger.


This is a bit different from other changelogs since we have some breaking changes. Currently it's not clear what exactly is breaking. Should we highlight that better specifically? Maybe something like:

Suggested change

- Exposes the missing public methods in the messenger.

### Added

- Expose missing public `UserStorageController` methods through its messenger ([#7976](https://github.com/MetaMask/core/pull/7976/))

- The following actions are now available:

- `UserStorageController:performDeleteStorageAllFeatureEntries`

- `UserStorageController:listEntropySources`

- `UserStorageController:setIsBackupAndSyncFeatureEnabled`

- `UserStorageController:setIsContactSyncingInProgress`

- `UserStorageController:syncContactsWithUserStorage`

- Corresponding action types (e.g. `UserStorageControllerPerformDeleteStorageAllFeatureEntriesAction`) are available as well.

### Changed

- **BREAKING:** Standardize names of `AuthenticationController` and `UserStorageController` messenger action types ([#7976](https://github.com/MetaMask/core/pull/7976/))

- All existing types for messenger actions have been renamed so they end in `Action` (e.g. `AuthenticationControllerPerformSignIn` -> `AuthenticationControllerPerformSignInAction`). You will need to update imports appropriately.

- This change only affects the types. The action type strings themselves have not changed, so you do not need to update the list of actions you pass when initializing `AuthenticationController` and `UserStorageController` messengers.

mcmire · 2026-02-20T16:35:51Z

packages/subscription-controller/CHANGELOG.md

 - Bump `@metamask/transaction-controller` from `^62.16.0` to `^62.18.0` ([#7897](https://github.com/MetaMask/core/pull/7897), [#7996](https://github.com/MetaMask/core/pull/7996), [#8005](https://github.com/MetaMask/core/pull/8005))
 - Bump `@metamask/polling-controller` from `^16.0.2` to `^16.0.3` ([#7996](https://github.com/MetaMask/core/pull/7996))
 - Bump `@metamask/controller-utils` from `^11.18.0` to `^11.19.0` ([#7995](https://github.com/MetaMask/core/pull/7995))
+- Update `AuthenticationController` actions to their new names ([#7976](https://github.com/MetaMask/core/pull/7976))


Suggested change

- Update `AuthenticationController` actions to their new names ([#7976](https://github.com/MetaMask/core/pull/7976))

GuillaumeRx requested a review from a team as a code owner February 18, 2026 11:14

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 7de355d to 0e42ff2 Compare February 18, 2026 11:15

GuillaumeRx commented Feb 18, 2026

View reviewed changes

cursor bot reviewed Feb 18, 2026

View reviewed changes

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts Outdated Show resolved Hide resolved

hmalik88 reviewed Feb 18, 2026

View reviewed changes

packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.ts Outdated Show resolved Hide resolved

mcmire reviewed Feb 18, 2026

View reviewed changes

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 0e42ff2 to 6ea2c28 Compare February 19, 2026 15:10

GuillaumeRx requested review from a team as code owners February 19, 2026 15:10

GuillaumeRx commented Feb 19, 2026

View reviewed changes

cursor bot reviewed Feb 19, 2026

View reviewed changes

packages/account-tree-controller/src/types.ts Outdated Show resolved Hide resolved

GuillaumeRx requested review from a team as code owners February 19, 2026 15:30

GuillaumeRx changed the title ~~chore: Expose Accounts-owned controller/service methods through messenger~~ feat!: Expose Accounts-owned controller/service methods through messenger Feb 20, 2026

GuillaumeRx requested a review from a team as a code owner February 20, 2026 10:44

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch 2 times, most recently from be1d092 to 405c239 Compare February 20, 2026 11:19

GuillaumeRx commented Feb 20, 2026

View reviewed changes

GuillaumeRx added 8 commits February 20, 2026 14:02

migrate AccountsController to use registerMethodActionHandlers

271e0cd

migrate MultichainAccountService to use registerMethodActionHandlers

2635b01

migrate AccountTreeController, AuthenticationController and `User…

0cc9967

…StorageController`

fix action name

e7322e2

use generate-method-action-types in account-tree-controller

c78f96b

use generate-method-action-types in accounts-controller

000c741

use generate-method-action-types in multichain-account-service

926052c

use generate-method-action-types in profile-sync-controller

2c604d4

GuillaumeRx added 14 commits February 20, 2026 14:02

revert typo

a79fc19

fix import

5418e3b

fix action name usage

d6e1fe9

fix lint and exports

efec6bf

use type only imports

47cdaed

fix account-tree-controller type imports

58fc302

fix lint, rename actions in other controllers

7e9d46b

fill coverage in AccountsController

47419ab

update CHANGELOGs

0ff1bd8

fix core-backend CHANGELOG

e91e209

fix core-backend CHANGELOG

a84ed9e

fix eslint-suppressions.json lint

9653421

fix claims-controller changelog

80fba50

fix multichain-account-service tests

6867941

GuillaumeRx force-pushed the gr/expose-accounts-methods-messenger branch from 31e2baa to 6867941 Compare February 20, 2026 13:04

cursor bot reviewed Feb 20, 2026

View reviewed changes

packages/multichain-account-service/src/MultichainAccountService.test.ts Show resolved Hide resolved

remove direct call to method in test

7ec9ffb

mcmire reviewed Feb 20, 2026

View reviewed changes

-- Bump `@metamask/accounts-controller` from `^36.0.0` to `^36.0.1` ([#7996](https://github.com/MetaMask/core/pull/7996))
+### Removed
+- **BREAKING:** Remove `resolveNameConflict` from `AccountTreeController` ([#7976](https://github.com/MetaMask/core/pull/7976))
+  - This method was only used internally.

-### Changed
-- Refactor the controller's messenger action registration ([#7976](https://github.com/MetaMask/core/pull/7976/))
-  - The controller's methods are now exposed to the messenger through `registerMethodActionHandlers` and `MESSENGER_EXPOSED_METHODS`.
-  - The action types are now generated using `generate-method-action-types`.
-  - Exposes the missing public methods in the messenger.
+### Added
+- Expose missing public `AccountTreeController` methods through its messenger ([#7976](https://github.com/MetaMask/core/pull/7976/))
+  - The following actions are now available:
+    - `AccountTreeController:getAccountWalletObject`
+    - `AccountTreeController:getAccountWalletObjects`
+    - `AccountTreeController:getAccountGroupObject`
+    - `AccountTreeController:clearState`
+    - `AccountTreeController:syncWithUserStorage`
+    - `AccountTreeController:syncWithUserStorageAtLeastOnce`
+  - Corresponding action types (e.g. `AccountTreeControllerGetAccountWalletObjectAction`) are available as well.


		### Changed

		- Refactor the controller's messenger action registration ([#7976](https://github.com/MetaMask/core/pull/7976/))


		### Changed

		- Update `AuthenticationController` action to its new name ([#7976](https://github.com/MetaMask/core/pull/7976))

-  - Exposes the missing public methods in the messenger.
+### Added
+- Expose missing public `UserStorageController` methods through its messenger ([#7976](https://github.com/MetaMask/core/pull/7976/))
+  - The following actions are now available:
+    - `UserStorageController:performDeleteStorageAllFeatureEntries`
+    - `UserStorageController:listEntropySources`
+    - `UserStorageController:setIsBackupAndSyncFeatureEnabled`
+    - `UserStorageController:setIsContactSyncingInProgress`
+    - `UserStorageController:syncContactsWithUserStorage`
+  - Corresponding action types (e.g. `UserStorageControllerPerformDeleteStorageAllFeatureEntriesAction`) are available as well.
+### Changed
+- **BREAKING:** Standardize names of `AuthenticationController` and `UserStorageController` messenger action types ([#7976](https://github.com/MetaMask/core/pull/7976/))
+  - All existing types for messenger actions have been renamed so they end in `Action` (e.g. `AuthenticationControllerPerformSignIn` -> `AuthenticationControllerPerformSignInAction`). You will need to update imports appropriately.
+  - This change only affects the types. The action type strings themselves have not changed, so you do not need to update the list of actions you pass when initializing `AuthenticationController` and `UserStorageController` messengers.

Uh oh!

Comments

Conversation

GuillaumeRx commented Feb 18, 2026 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

References

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mcmire left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

GuillaumeRx commented Feb 18, 2026 •

edited by cursor bot

Loading