feat(transaction-pay-controller): alternate relay deposit types#7947
Open
matthewwalsh0 wants to merge 3 commits intomainfrom
Open
feat(transaction-pay-controller): alternate relay deposit types#7947matthewwalsh0 wants to merge 3 commits intomainfrom
matthewwalsh0 wants to merge 3 commits intomainfrom
Conversation
48e4408 to
9bb4168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Replace
relayDeposittransaction type withpredictRelayDepositorperpsRelayDepositbased on the parent transaction type (predictDepositorperpsDeposit). Falls back torelayDepositfor unmapped parent types.References
N/A
Checklist
Note
Medium Risk
Touches transaction classification used during Relay submission (including batch/post-quote paths), which can affect downstream tracking/metrics if consumers don’t handle the new
TransactionTypevalues correctly.Overview
Relay deposit transactions created by
transaction-pay-controllerare now typed based on their parent flow:predictDepositmaps topredictRelayDepositandperpsDepositmaps toperpsRelayDeposit, with a fallback torelayDepositfor all other parents.This introduces two new
TransactionTypeenum values intransaction-controller, adds aRELAY_DEPOSIT_TYPESmapping used byrelay-submit.ts(including in batched and post-quote flows), and expands the Relay submit tests/changelogs to cover the new behavior.Written by Cursor Bugbot for commit c912fee. This will update automatically on new commits. Configure here.