Skip to content

Add attribution metadat policy for BIG_DATA#610

Open
Yaswant Pradhan (yaswant) wants to merge 12 commits into
MetOffice:mainfrom
yaswant:big-data-policy
Open

Add attribution metadat policy for BIG_DATA#610
Yaswant Pradhan (yaswant) wants to merge 12 commits into
MetOffice:mainfrom
yaswant:big-data-policy

Conversation

@yaswant
Copy link
Copy Markdown
Contributor

@yaswant Yaswant Pradhan (yaswant) commented Mar 31, 2026

PR Summary

IAO Approver: Ben Fitzpatrick (@benfitzpatrick)
Code Reviewer: Sam Clarke-Green (@t00sa)

Cc: Andrew Clark (@arjclark)

Adding attribution metadata policy to working practices.

Code Quality Checklist

IAO Comments

Code Review

  • The changes are coherent and valid

@t00sa
Copy link
Copy Markdown
Collaborator

This is a good start, but there are no rules for developers. Without clear guidance on what sort of data can be added and what the supporting evidence is required, this will result in more problems during review.

The PR also seems to be doing two things: adding information about the big data policy, and fixing typos and changing build instructions in other sections. These are separate and the second part needs to be split out into another PR.

@yaswant
Copy link
Copy Markdown
Contributor Author

Good points, Sam Clarke-Green (@t00sa) - I initially thought this would be best placed in the Developer section, but since the reference to BIG_DATA was only in the Reviewer section, that's where it ended up. You're correct that some adjustments are needed. Regarding what's permitted, ANCILDIR-Deploy should be considered the single source of truth.

I'll revert the typo and jules-doc compilation updates and address them in another PR.

Comment thread source/Reviewers/howtocommit.rst Outdated

Please refer to the
`Prerequisites section of the ANCILDIR-Deploy document
<https://github.com/MetOffice/ANCILDIR-Deploy?tab=readme-ov-file#prerequisites>`__.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, one issue might be that collaborators can't see this one - it's deliberately not collaborator visible. Andy is happy that you extract / quote it here if you want.

@yaswant
Copy link
Copy Markdown
Contributor Author

Thanks both.

Moved the guidance to development checklist section. Included process (extract from ANCILDIR-Deploy) here for wider visibility.

Copy link
Copy Markdown
Collaborator

@t00sa Sam Clarke-Green (t00sa) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments in-line

Comment thread source/Development/testdata.rst Outdated
If the change requires a new or updated file in ``LFRIC_DATA_DIR`` then you
will need to work with the Information Asset Owner (IAO) to ensure that data
in ``LFRIC_DATA_DIR`` must include clear attribution and licence metadata.
Where possible, this should follow existing UM ``ANCILDIR`` conventions (`see
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better not to imply that this is optional:

Suggested change
Where possible, this should follow existing UM ``ANCILDIR`` conventions (`see
This should follow existing UM ``ANCILDIR`` conventions (`see

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For LFRic, we prefer to include the metadata and license as NetCDF global attributes rather than storing them separately. This approach does not currently apply to UM ANCILDIR.

For non-NetCDF LFRic files, we follow UM ANCILDIR convention.

Comment thread source/Development/testdata.rst Outdated
Comment thread source/Development/testdata.rst Outdated
Comment thread source/Development/testdata.rst Outdated
Comment thread source/Development/testdata.rst Outdated
Comment thread source/Development/testdata.rst Outdated
Comment thread source/Development/testdata.rst Outdated
Comment on lines +69 to +70
In cases where a file has been generated from multiple sources, it should be
made clear where each licence/attribution/acknowledgement has come from.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In cases where a file has been generated from multiple sources, it should be
made clear where each licence/attribution/acknowledgement has come from.
In cases where a file has been generated from multiple sources, the liccences
must be compatible with each other and it should be made clear where each licence/attribution/acknowledgement has come from.

Comment thread source/Development/testdata.rst Outdated
Apply CR suggestion

Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Apply CR suggestion

Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Apply CR suggestion

Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Apply CR suggestion

Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Apply CR suggestion

Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Apply CR suggestion

Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Apply CR suggestion.

Co-authored-by: Sam Clarke-Green <74185251+t00sa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants