Skip to content

fix build job name inconsistence from nn-bit to nnbit#344

Open
Joe Hickson (joeHickson) wants to merge 4 commits into
MetOffice:mainfrom
joeHickson:build-test-group-naming
Open

fix build job name inconsistence from nn-bit to nnbit#344
Joe Hickson (joeHickson) wants to merge 4 commits into
MetOffice:mainfrom
joeHickson:build-test-group-naming

Conversation

@joeHickson
Copy link
Copy Markdown

@joeHickson Joe Hickson (joeHickson) commented Apr 23, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Pierre Siddall (@Pierre-siddall)

fix the group=build where some tasks had drifted into -00-bit rather than -00bit

image

this currently causes the group=build to thrown an error.
image

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • [n/a] Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite https://cylchub/services/cylc-review/taskjobs/joseph.hickson/?suite=build-test-group-naming-dev%2Frun1
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • [n/a ] If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • [n/a] I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • [n/a] Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - build-test-group-naming-dev/run1

Suite Information

Item Value
Suite Name build-test-group-naming-dev/run1
Suite User joseph.hickson
Workflow Start 2026-04-23T12:46:14
Groups Run developer
Dependency Reference Main Like
lfric_core joeHickson/lfric_core@build-test-group-naming False
SimSys_Scripts MetOffice/SimSys_Scripts@2025.12.1 True

Task Information

✅ succeeded tasks - 384

Security Considerations

  • [n/a] I have reviewed my changes for potential security issues
  • [n/a] Sensitive data is properly handled (if applicable)
  • [n/a] Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • [n/a] Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

none

Documentation

  • [n/a] Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • [n/a] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@github-actions github-actions Bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Apr 23, 2026
@github-actions github-actions Bot added cla-signed The CLA has been signed as part of this PR - added by GA and removed cla-required The CLA has not yet been signed by the author of this PR - added by GA labels Apr 23, 2026
@joeHickson Joe Hickson (joeHickson) marked this pull request as ready for review April 23, 2026 13:10
@joeHickson Joe Hickson (joeHickson) requested a review from a team as a code owner April 23, 2026 13:10
@joeHickson Joe Hickson (joeHickson) requested review from Matthew Hambley (MatthewHambley) and removed request for a team April 23, 2026 13:10
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I was tapped for review, but this seems fairly uncontroversial to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants