Deprecate copy field halo kernel#341
Open
Alistair Pirrie (mo-alistairp) wants to merge 15 commits into
Open
Conversation
a671450 to
66b80d1
Compare
28 tasks
iboutle
reviewed
Apr 30, 2026
iboutle
requested changes
Apr 30, 2026
Thomas Bendall (tommbendall)
approved these changes
Apr 30, 2026
iboutle
approved these changes
May 6, 2026
Mike Hobson (mike-hobson)
requested changes
May 11, 2026
Contributor
Mike Hobson (mike-hobson)
left a comment
There was a problem hiding this comment.
This all looks very straightforward. I just have one very minor query.
Comment on lines
+770
to
+771
| mesh => field_out_proxy%vspace%get_mesh() | ||
| max_halo_depth_mesh = mesh%get_halo_depth() |
Contributor
There was a problem hiding this comment.
Apart from these lines and the declarations on line 760, 761, max_halo_depth_mesh and mesh don't appear to be used. Can they just be removed?
Contributor
Author
There was a problem hiding this comment.
Good spot, yes I think you're right. I'll remove it and check it hasn't affected anything
Contributor
Author
|
I've re-run with the removal and it's still passing fine |
Mike Hobson (mike-hobson)
approved these changes
May 12, 2026
Contributor
Mike Hobson (mike-hobson)
left a comment
There was a problem hiding this comment.
I'm happy - onto BenW for code review...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Mike Hobson (@mike-hobson)
Code Reviewer: Benjamin Went (@MetBenjaminWent)
This PR replaces
copy_field_halo_kernel_mod.f90with a temporary PSyKAl-lite script. This is documented in issue #334. The PSyKAl-lite script will search for the last clean halo and copy the field up to that point in a DoF-wise manner.linked MetOffice/lfric_apps#471
is related to #334
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - deprecate_copy_field_halo_core/run1
Suite Information
Task Information
✅ succeeded tasks - 390
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review